Repository navigation
Javadoc: Note that parsed option values are converted on every call - #447
Merged
garydgregory merged 1 commit intoOct 29, 2026
Merged
Conversation
getParsedOptionValue() and getParsedOptionValues() run the option's Converter each time they are called and don't cache the result. That doesn't matter for numbers or strings, but with a converter that has side effects, like the default FileInputStream one, every call opens a new stream. Mention it in the CommandLine class Javadoc. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
garydgregory
added a commit
that referenced
this pull request
Oct 29, 2026
Member
garydgregory
added a commit
that referenced
this pull request
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommandLine.getParsedOptionValue()andgetParsedOptionValues()run the option's converter every time they're called; nothing is cached. That's harmless for numbers or strings, but it's easy to be caught out with a converter that has side effects. With aFileInputStreamoption, for example, every call opens a new stream that the caller has to close.This adds a short paragraph about it to the
CommandLineclass Javadoc. I didn't add caching on purpose: it would change behavior, because callers would start getting the same, possibly mutable, instance back from every call.Javadoc only, no behavior change.
mvn; that'smvnon the command line by itself.🤖 Generated with Claude Code