Skip to content

fix: Refine standalone partition slicing resolver support - #2907

Open
vikrantmehta123 wants to merge 1 commit into
apache:mainfrom
vikrantmehta123:followup/2886-resolver-review
Open

vikrantmehta123 wants to merge 1 commit into
apache:mainfrom
vikrantmehta123:followup/2886-resolver-review

Conversation

@vikrantmehta123

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Follow-up to #2886.

Rationale for this change

This PR addresses Andy's review comments on #2886.

What changes are included in this PR?

  • Adds a default implementation to SessionConfigExt::ballista_partition_sliceable_resolver which returns None. This is updated in docs as well.
  • Updates the test to ensure that a resolver returning None leaves the query results unchanged.
  • "cannot restrict" errors in ballista/scheduler/src/state/task_builder.rs point to the standalone resolver methods too. There were two tests that had this "cannot restrict" error. One was related to Iceberg integration tests and the other one was scheduler test. I have updated the scheduler test, but not the iceberg test as the Iceberg workspace pins an older Ballista version (AI helped me identify this).

Are there any user-facing changes?

Yes. The error message now tells standalone users how to register a resolver. Downstream implementations of SessionConfigExt can omit the resolver getter and inherit its default. The setter remains required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant