Repository navigation
fix: Refine standalone partition slicing resolver support - #2907
Open
vikrantmehta123 wants to merge 1 commit into
Open
vikrantmehta123 wants to merge 1 commit into
vikrantmehta123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up to #2886.
Rationale for this change
This PR addresses Andy's review comments on #2886.
What changes are included in this PR?
SessionConfigExt::ballista_partition_sliceable_resolverwhich returnsNone. This is updated in docs as well.Noneleaves the query results unchanged.ballista/scheduler/src/state/task_builder.rspoint to the standalone resolver methods too. There were two tests that had this "cannot restrict" error. One was related to Iceberg integration tests and the other one was scheduler test. I have updated the scheduler test, but not the iceberg test as the Iceberg workspace pins an older Ballista version (AI helped me identify this).Are there any user-facing changes?
Yes. The error message now tells standalone users how to register a resolver. Downstream implementations of
SessionConfigExtcan omit the resolver getter and inherit its default. The setter remains required.