Repository navigation
docs: explain input types, casts and ANSI mode in the contributor guide - #360
Merged
Merged
Conversation
Describe SparkInputTypes, the common-type rules, spark_cast and EvalMode, which were added in apache#89, apache#304, apache#345 and apache#350, and point the audit skill at them.
Point to the module docs instead of restating them, and shorten the audit skill text to a pointer.
andygrove
marked this pull request as ready for review
November 18, 2026 18:06
Member
Author
|
cc @shehabgamin |
coderfender
approved these changes
Nov 18, 2026
| is already threaded through `ScalarFunctionArgs`, so the implementation reads | ||
| it directly: | ||
| is already threaded through `ScalarFunctionArgs`. Prefer an `EvalMode` over a | ||
| `bool` (see `CONTRIBUTING.md`), as `parse_url` and `try_parse_url` do: |
Contributor
There was a problem hiding this comment.
might have to make this a little bit stricter to make eval mode compulsory (at least in the top level function)
Member
Author
|
Thanks @coderfender |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
#89, #304, #345 and #350 added a shared way to declare a function's input types, find a common type, cast a value and read ANSI mode.
CONTRIBUTING.mddoes not mention any of them, so a new function is likely to hand-write aSignature, call Arrow'scast, or take aboolfor ANSI mode instead.What changes are included in this PR?
CONTRIBUTING.md. It says when to useSparkInputTypes, the rules intype_coercion.rs,spark_cast()andEvalMode, and points to the module docs for details.The section says that
SparkInputTypesonly chooses target types and thatspark_cast()returns "not implemented" for casts that are not ported yet (#88). I kept that wording on purpose, so it can be relaxed as the cast port progresses.Are these changes tested?
Documentation only. I checked each name, path and example against
apache/main(sha2.rs,parse_url.rs,array_position.rs,implicit_cast.rs,type_coercion.rs,eval_mode.rs,cast/mod.rs).Are there any user-facing changes?
No.
This PR was written with the help of an LLM (Claude Code).