Skip to content

test: skip nanvl records that need simplify in evaluate mode - #377

Merged
mbutrovich merged 1 commit into
apache:mainfrom
andygrove:fix-nanvl-slt
Nov 19, 2026
Merged

mbutrovich merged 1 commit into
apache:mainfrom
andygrove:fix-nanvl-slt

Conversation

@andygrove

@andygrove andygrove commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Which issue does this PR close?

Part of #376.

Rationale for this change

main fails CI since #301 and #316 landed together. conditional/nanvl.slt fails in the new evaluate mode, and the PySpark runner reports a difference at line 53.

What changes are included in this PR?

  • The seven records that need nanvl's simplify rewrite (a lazy expr2 under ANSI mode, and string arguments) are marked skipif evaluate, linking nanvl needs simplify for a lazy expr2 and for string arguments #376.
  • Line 53 used -0.0::double, which Spark types as a DECIMAL literal with no negative zero, so Spark returned false. It now uses '-0.0'::double, as log1p.slt does.

Are these changes tested?

nanvl.slt passes in both modes, and the PySpark runner reports no differences for it.

Are there any user-facing changes?

No.

nanvl's lazy expr2 and its string casts come only from its simplify
rewrite, so seven records fail in the evaluate mode added by apache#316. Skip them
there, linking apache#376. Also use '-0.0'::double, since Spark types -0.0 as a
DECIMAL literal, which has no negative zero.
@andygrove
andygrove requested a review from kosiew November 19, 2026 13:10

@mbutrovich mbutrovich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @andygrove!

@mbutrovich
mbutrovich merged commit 365521c into apache:main Nov 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants