Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2841 +/- ##
=======================================
Coverage 83.20% 83.21%
=======================================
Files 42 42
Lines 36471 36489 +18
Branches 36471 36489 +18
=======================================
+ Hits 30345 30363 +18
+ Misses 2632 2630 -2
- Partials 3494 3496 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
requested changes
Nov 7, 2026
LucaCappelletti94
approved these changes
Nov 12, 2026
LucaCappelletti94
left a comment
Contributor
There was a problem hiding this comment.
Please rebase it, but besides it seems ready to merge.
Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>
MrBisonte
force-pushed
the
feat/postgres-procedure-string-body
branch
from
November 12, 2026 20:20
7d35f4d to
477cf3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dialects: PostgreSQL, Generic
CREATE PROCEDURE insert_data(a integer, b integer) LANGUAGE SQL AS $$ INSERT INTO tbl VALUES (a); INSERT INTO tbl VALUES (b); $$, the first example of https://www.postgresql.org/docs/current/sql-createprocedure.html, failed withExpected: an SQL statement, found: $$ ....parse_create_procedureread everything afterASas statements, the MSSQL form, so a single quoted body,AS 'definition', failed the same way.A string after
ASnow becomesCreateProcedureBody::AsString { body, link_symbol }, read by the code that already reads aCREATE FUNCTIONstring body, moved intoparse_definition_string.LANGUAGEmay also follow the string, and prints beforeAS, as it does forCREATE FUNCTION. Any other token afterASkeeps the statement path.CREATE OR REPLACE PROCEDUREis still rejected, and will follow in its own PR.Written with an AI coding assistant.