Skip to content

PostgreSQL: Support EXTENSION members in ALTER EXTENSION #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LucaCappelletti94 wants to merge 1 commit into from
+8 −0
Open

PostgreSQL: Support EXTENSION members in ALTER EXTENSION #2937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions fuzz/fuzz_seeds/postgres_alter_extension.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ ALTER EXTENSION citext ADD TEXT SEARCH DICTIONARY public.dict;
ALTER EXTENSION citext DROP TEXT SEARCH PARSER public.pgrm;
ALTER EXTENSION citext ADD TEXT SEARCH TEMPLATE public.tpl;
ALTER EXTENSION citext DROP DATABASE db_name;
ALTER EXTENSION citext ADD EXTENSION other_ext;
3 changes: 3 additions & 0 deletions src/ast/ddl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4940,6 +4940,8 @@ pub enum AlterExtensionMember {
Database(Ident),
/// `EVENT TRIGGER object_name`
EventTrigger(Ident),
/// `EXTENSION object_name`
Extension(Ident),
/// `FOREIGN DATA WRAPPER object_name`
ForeignDataWrapper(Ident),
/// `FOREIGN TABLE object_name`
Expand Down Expand Up @@ -5000,6 +5002,7 @@ impl fmt::Display for AlterExtensionMember {
AlterExtensionMember::Conversion(name) => write!(f, "CONVERSION {name}"),
AlterExtensionMember::Database(name) => write!(f, "DATABASE {name}"),
AlterExtensionMember::EventTrigger(name) => write!(f, "EVENT TRIGGER {name}"),
AlterExtensionMember::Extension(name) => write!(f, "EXTENSION {name}"),
AlterExtensionMember::ForeignDataWrapper(name) => {
write!(f, "FOREIGN DATA WRAPPER {name}")
}
Expand Down
2 changes: 2 additions & 0 deletions src/parser/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12553,6 +12553,8 @@ impl<'a> Parser<'a> {
Ok(AlterExtensionMember::Database(self.parse_identifier()?))
} else if self.parse_keywords(&[Keyword::EVENT, Keyword::TRIGGER]) {
Ok(AlterExtensionMember::EventTrigger(self.parse_identifier()?))
} else if self.parse_keyword(Keyword::EXTENSION) {
Ok(AlterExtensionMember::Extension(self.parse_identifier()?))
} else if self.parse_keywords(&[Keyword::FOREIGN, Keyword::DATA, Keyword::WRAPPER]) {
Ok(AlterExtensionMember::ForeignDataWrapper(
self.parse_identifier()?,
Expand Down
2 changes: 2 additions & 0 deletions tests/sqlparser_postgres.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13534,6 +13534,7 @@ fn alter_extension_member_round_trip_forms(action: &str) {
format!("ALTER EXTENSION ext_name {action} CONVERSION conv"),
format!("ALTER EXTENSION ext_name {action} DATABASE db_name"),
format!("ALTER EXTENSION ext_name {action} EVENT TRIGGER trg"),
format!("ALTER EXTENSION ext_name {action} EXTENSION other_ext"),
format!("ALTER EXTENSION ext_name {action} FOREIGN DATA WRAPPER fdw"),
format!("ALTER EXTENSION ext_name {action} FOREIGN TABLE ft"),
format!("ALTER EXTENSION ext_name {action} FOREIGN TABLE schema.ft"),
Expand Down Expand Up @@ -13730,6 +13731,7 @@ fn parse_alter_extension_add_member() {
"CONVERSION",
"DATABASE",
"EVENT TRIGGER",
"EXTENSION",
"FOREIGN DATA WRAPPER",
"FOREIGN TABLE",
"LANGUAGE",
Expand Down
Loading