Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions fuzz/fuzz_seeds/postgres_alter_extension.sql
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@ ALTER EXTENSION citext DROP SUBSCRIPTION sub;
ALTER EXTENSION citext ADD TABLESPACE ts;
ALTER EXTENSION citext ADD FUNCTION public.f(IN a int, text);
ALTER EXTENSION citext DROP PROCEDURE public.p(int);
ALTER EXTENSION citext ADD ROUTINE public.r(int);
3 changes: 3 additions & 0 deletions src/ast/ddl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4963,6 +4963,8 @@ pub enum AlterExtensionMember {
Procedure(FunctionDesc),
/// `PUBLICATION object_name`
Publication(Ident),
/// `ROUTINE routine_name [ ( [ [ argmode ] [ argname ] argtype [, ...] ] ) ]`
Routine(FunctionDesc),
/// `ROLE object_name`
Role(Ident),
/// `SCHEMA object_name`
Expand Down Expand Up @@ -5035,6 +5037,7 @@ impl fmt::Display for AlterExtensionMember {
AlterExtensionMember::MaterializedView(name) => write!(f, "MATERIALIZED VIEW {name}"),
AlterExtensionMember::Procedure(function) => write!(f, "PROCEDURE {function}"),
AlterExtensionMember::Publication(name) => write!(f, "PUBLICATION {name}"),
AlterExtensionMember::Routine(function) => write!(f, "ROUTINE {function}"),
AlterExtensionMember::Role(name) => write!(f, "ROLE {name}"),
AlterExtensionMember::Schema(name) => write!(f, "SCHEMA {name}"),
AlterExtensionMember::Sequence(name) => write!(f, "SEQUENCE {name}"),
Expand Down
2 changes: 2 additions & 0 deletions src/parser/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12585,6 +12585,8 @@ impl<'a> Parser<'a> {
Ok(AlterExtensionMember::Procedure(self.parse_function_desc()?))
} else if self.parse_keyword(Keyword::PUBLICATION) {
Ok(AlterExtensionMember::Publication(self.parse_identifier()?))
} else if self.parse_keyword(Keyword::ROUTINE) {
Ok(AlterExtensionMember::Routine(self.parse_function_desc()?))
} else if self.parse_keyword(Keyword::ROLE) {
Ok(AlterExtensionMember::Role(self.parse_identifier()?))
} else if self.parse_keyword(Keyword::SCHEMA) {
Expand Down
6 changes: 6 additions & 0 deletions tests/sqlparser_postgres.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13550,6 +13550,8 @@ fn alter_extension_member_round_trip_forms(action: &str) {
format!("ALTER EXTENSION ext_name {action} PROCEDURE p()"),
format!("ALTER EXTENSION ext_name {action} PROCEDURE p(INT)"),
format!("ALTER EXTENSION ext_name {action} PUBLICATION pub"),
format!("ALTER EXTENSION ext_name {action} ROUTINE r"),
format!("ALTER EXTENSION ext_name {action} ROUTINE r()"),
format!("ALTER EXTENSION ext_name {action} ROLE role_name"),
format!("ALTER EXTENSION ext_name {action} SCHEMA schema_name"),
format!("ALTER EXTENSION ext_name {action} SEQUENCE seq"),
Expand Down Expand Up @@ -13752,6 +13754,10 @@ fn parse_alter_extension_add_member() {
"ALTER EXTENSION ext_name ADD PROCEDURE 1",
"Expected: identifier, found: 1",
),
(
"ALTER EXTENSION ext_name ADD ROUTINE 1",
"Expected: identifier, found: 1",
),
] {
assert_eq!(
pg_and_generic().parse_sql_statements(sql).unwrap_err(),
Expand Down
Loading