Skip to content

PostgreSQL: Represent ALTER AGGREGATE signatures with one type - #2949

Open
LucaCappelletti94 wants to merge 1 commit into
upstream/pg-alter-extension-member-routinefrom
upstream/pg-alter-aggregate-signature
Open

LucaCappelletti94 wants to merge 1 commit into
upstream/pg-alter-extension-member-routinefrom
upstream/pg-alter-aggregate-signature

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

AlterFunction described an ALTER AGGREGATE signature with a FunctionDesc plus two aggregate-only fields, aggregate_star and aggregate_order_by. That shape allows a * signature that also has arguments, and an argument list of None that the parser never produces.

The next PR in the stack will reuse AggregateSignature for ALTER EXTENSION ... ADD AGGREGATE.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.32%. Comparing base (d66fdf5) to head (69d9328).

Additional details and impacted files
@@                              Coverage Diff                               @@
##           upstream/pg-alter-extension-member-routine    #2949      +/-   ##
==============================================================================
+ Coverage                                       83.28%   83.32%   +0.04%     
==============================================================================
  Files                                              42       42              
  Lines                                           35439    35419      -20     
  Branches                                        35439    35419      -20     
==============================================================================
- Hits                                            29515    29514       -1     
+ Misses                                           2478     2476       -2     
+ Partials                                         3446     3429      -17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants