feat: support binary types in octet_length - #24867
Merged
Merged
Conversation
octet_length now accepts Binary, LargeBinary, and BinaryView. The signature uses the same shape as md5 and digest. LargeBinary returns Int64. The other two return Int32. No coercion to Utf8 runs. Thus the function counts the raw bytes of non-UTF-8 input. Also reword the message in get_optimal_return_type! to "strings or binary".
github-actions
Bot
added
sqllogictest
comphead
reviewed
Sep 2, 2026
comphead
reviewed
Sep 2, 2026
comphead
left a comment
comphead
left a comment
Contributor
There was a problem hiding this comment.
Thanks @eddietejeda for the PR, commented
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24867 +/- ##
=======================================
Coverage 81.60% 81.60%
=======================================
Files 1123 1123
Lines 411514 411604 +90
Branches 411514 411604 +90
=======================================
+ Hits 335811 335894 +83
- Misses 55924 55932 +8
+ Partials 19779 19778 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Switch the binary signature from Native(logical_binary()) to TypeSignatureClass::Binary, which admits FixedSizeBinary. TypeSignatureClass::Binary now coerces a NULL argument to Binary instead of passing DataType::Null downstream. Updated end user documentation.
github-actions
Bot
added
documentation
Contributor
Author
|
Thanks for your feedback, @comphead. Anything else before merging? |
comphead
approved these changes
Sep 10, 2026
comphead
left a comment
comphead
left a comment
Contributor
There was a problem hiding this comment.
Thanks @eddietejeda looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
octet_lengthshould accept binary types #24765.Rationale for this change
octet_lengthshould count the raw bytes of binary data without expensive encoding workaround.What changes are included in this PR?
Binary,LargeBinary, andBinaryView.Int64forLargeBinaryandInt32for the other types.What is the testing strategy for this PR?
Unit and SQL logic tests cover binary arrays and scalars, non-UTF-8 data, nulls, dictionary encoding, and return types.
Are there any user-facing changes?
Yes.
octet_lengthnow counts the raw bytes of binary values. Existing string behavior is unchanged.