Repository navigation
Add suport for wrapped_compact_tuple_sketch - #520
SavicStefan wants to merge 1 commit into
Conversation
Signed-off-by: Stefan Savić <stefan.savic@databricks.com>
|
@apache/datasketches-committers P.S Sorry for not doing this properly via mailing list, but I saw in last PR that no one responded via it. |
proost
left a comment
There was a problem hiding this comment.
This PR moves existing virtual methods into base_tuple_sketch and inserts print_items before the iterator methods in the virtual layout. So This makes ABI breaking change.
Normal full recompilation will generally work because the project is header-only, but objects crossing shared-library/plugin boundaries are ABI-incompatible.
|
@SavicStefan, |
|
I am closing this PR. There has been no response on this PR for nearly a month. We are preparing for some major releases and if the author feels that it is important it can be reopened later. |
Summary
This PR adds
wrapped_compact_tuple_sketch, a non-owning view over aserialized compact tuple sketch. It follows the same model as
wrapped_compact_theta_sketch: callers can use a serialized sketch withoutmaterializing all retained entries in an owning vector.
How it works
wrap()validates the header, sketch type, family, seed hash, metadata,and complete serialized payload.
caller must keep the serialized buffer alive.
aligned in-place storage.
base_tuple_sketchprovides APIs shared by materialized andwrapped_compact_tuple_sketch.wrapped representation.
This avoids memory use proportional to the retained-entry count. Fixed-
width summaries require no heap storage for entries. Variable-width
summaries, such as strings, may still allocate internally, but the wrapper
materializes only one entry at a time.
Tests
Tests cover: