Skip to content

Fix build with GCC 14: drop const from vector_of_kll_sketches k_ and d_ #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zeniel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix build with GCC 14: drop const from vector_of_kll_sketches k_ and d_ #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/vector_of_kll.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ class vector_of_kll_sketches {
template<typename TT>
Array2D<TT> make_ndarray(size_t rows, size_t cols) const;

const uint32_t k_; // kll sketch k parameter
const uint32_t d_; // number of dimensions (here: sketches) to hold
uint32_t k_; // kll sketch k parameter
uint32_t d_; // number of dimensions (here: sketches) to hold
std::vector<kll_sketch<T, C>> sketches_;
};

Expand Down