Repository navigation
test: update TCK snapshots and archive layout - #292
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the pinned DataSketches TCK revision from
c0a180708c6e6433e4cba7fba091713eb8af3eaato8193bab45ca5da3b513ea43fb5793e7e5b4da548.Adapt
cargo x prepare-testdatato read the new upstreamserialization_test_data/<language>_generated_fileslayout and update the preparation instructions. Add compatibility tests for the new C++ and Java frequent-items snapshots whose counters have all been purged, checking that the non-empty stream state, total weight, error, and serialized bytes are preserved.Validation:
cargo x prepare-testdatadownloaded 202 C++, 253 Go, and 276 Java snapshots. All 731 file names and Git blob hashes match the pinned TCK tree.cargo x check,cargo x test(757 tests, including all four new compatibility cases), andcargo x lintpassed.