FINERACT-2455: Working Capital - Consistent breach reprocessing & No backdated breach pause before reset - #6436
Merged
adamsaghy merged 3 commits intoSep 23, 2026
Conversation
alberto-art3ch
marked this pull request as ready for review
September 12, 2026 18:02
alberto-art3ch
force-pushed
the
FINERACT-2455/working-capital-not-allow-backdated-breach-pause
branch
2 times, most recently
from
September 19, 2026 23:34
569fcda to
6852679
Compare
alberto-art3ch
force-pushed
the
FINERACT-2455/working-capital-not-allow-backdated-breach-pause
branch
from
September 21, 2026 17:00
b545c22 to
db24025
Compare
adamsaghy
force-pushed
the
FINERACT-2455/working-capital-not-allow-backdated-breach-pause
branch
from
September 22, 2026 15:33
db24025 to
5100559
Compare
adamsaghy
force-pushed
the
FINERACT-2455/working-capital-not-allow-backdated-breach-pause
branch
from
September 23, 2026 09:15
5100559 to
68a05c1
Compare
… - No backdated breach pause
ruzeynalov
force-pushed
the
FINERACT-2455/working-capital-not-allow-backdated-breach-pause
branch
from
September 23, 2026 10:42
68a05c1 to
095c96a
Compare
adamsaghy
deleted the
FINERACT-2455/working-capital-not-allow-backdated-breach-pause
branch
September 23, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two related changes to how breach actions reshape the breach schedule.
No backdated breach pause behind an active reset. A reset settles the breach
period it lands on and restarts the evaluation from its own date, while a pause
re-dates every period it precedes. A pause starting before the latest active
reset would therefore re-date periods the reset already settled, so it is now
rejected. Resets that were undone do not block, since the undo restores the
split. The reset's cut also has to survive the pause replay: it is applied after
the pauses, because a pause recorded inside the period before the reset would
otherwise re-open it.
Consistent breach reprocessing. Pause, resume and reschedule now go through
one replay of the recorded actions, in chronological order (start date, then
creation instant). Per period: the natural length of the parameters in force
over it, then the pauses it meets, then the cut of a restart reset landing
inside it. This fixes two defects in the reschedule path:
frequency — the parameters are resolved per period, from the reschedule that
lands on it, instead of resolving the whole schedule against the latest one;
which the previous partial re-dating dropped.
The replay is idempotent, so a later action lands on the same schedule instead
of silently moving it. When the new action is the last one on the timeline only
the period it lands on and the ones after it are replayed; behind an already
recorded action the schedule is rebuilt from the start.
Covered by unit tests, integration tests and e2e scenarios. Breach actions are
replayed on their own timeline, so a pause may be backdated, but no scenario
moves the business date backwards.
FINERACT-2455
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.