Skip to content

FINERACT-2455: WC - Backdated discount fee adjustment on a re-charged-off loan - #6466

Open
somasorosdpc wants to merge 2 commits into
apache:developfrom
openMF:FINERACT-2455/wc-backdated-discount-fee-adjustment-on-re-charged-off-loan
Open

somasorosdpc wants to merge 2 commits into
apache:developfrom
openMF:FINERACT-2455/wc-backdated-discount-fee-adjustment-on-re-charged-off-loan

Conversation

@somasorosdpc

Copy link
Copy Markdown
Contributor

Backdated discount fee adjustment on a re-charged-off loan should correct realized income

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.
  • I followed the AI Policy.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@somasorosdpc
somasorosdpc force-pushed the FINERACT-2455/wc-backdated-discount-fee-adjustment-on-re-charged-off-loan branch 2 times, most recently from 7331841 to 0a13b2e Compare September 18, 2026 12:31
@adamsaghy
adamsaghy marked this pull request as ready for review September 21, 2026 14:36

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the below minor items:

  • WorkingCapitalLoanChargeOff.feature:509 — | totalDiscountFeeAdjustment | 000.0 |. Parses fine as BigDecimal("000.0"), but it looks like a typo; 0.0 pads the column equally well.

  • WorkingCapitalLoanChargeOff.feature:474 — the Step 2 comment says "repayment 50; run COB (amortization 9.61)", but COB runs before the repayment there and processes only 01 January, so it emits nothing. The 9.61 amortization actually comes from the Step 3 COB at business date 04 January. Worth reordering the comment so the next reader isn't misled.

  • WorkingCapitalLoanChargeOff.feature:487 — Customer undo "1"th working capital transaction made on "03 January 2026" uses the untyped undo step, which filters by date only and indexes by id order. At that point two transactions share 03 January (the repayment and the final amortization it triggered); it happens to pick the repayment because the repayment gets the lower id, but the typed variant the other scenario uses (Customer undo "1"th "Repayment" transaction made on … on Working Capital loan) says the intent explicitly and is immune to insertion-order changes.

somasorosdpc and others added 2 commits September 22, 2026 13:17
…-off loan should correct realized income e2e tests
…discount fee adjustment on a re-charged-off loan should correct realized income e2e tests
@somasorosdpc
somasorosdpc force-pushed the FINERACT-2455/wc-backdated-discount-fee-adjustment-on-re-charged-off-loan branch from 798a5d1 to 51c420b Compare September 22, 2026 11:18
@somasorosdpc

Copy link
Copy Markdown
Contributor Author

@adamsaghy I fixed all issues:

  • Changed 000.0 to 0.0
  • Corrected Step 2/3 comments to reflect COB order and amortization timing
  • Used the typed "Repayment" undo step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants