FINERACT-2455: WC - Backdated discount fee adjustment on a re-charged-off loan - #6466
Conversation
7331841 to
0a13b2e
Compare
adamsaghy
left a comment
There was a problem hiding this comment.
Please review the below minor items:
-
WorkingCapitalLoanChargeOff.feature:509 — | totalDiscountFeeAdjustment | 000.0 |. Parses fine as BigDecimal("000.0"), but it looks like a typo; 0.0 pads the column equally well.
-
WorkingCapitalLoanChargeOff.feature:474 — the Step 2 comment says "repayment 50; run COB (amortization 9.61)", but COB runs before the repayment there and processes only 01 January, so it emits nothing. The 9.61 amortization actually comes from the Step 3 COB at business date 04 January. Worth reordering the comment so the next reader isn't misled.
-
WorkingCapitalLoanChargeOff.feature:487 — Customer undo "1"th working capital transaction made on "03 January 2026" uses the untyped undo step, which filters by date only and indexes by id order. At that point two transactions share 03 January (the repayment and the final amortization it triggered); it happens to pick the repayment because the repayment gets the lower id, but the typed variant the other scenario uses (Customer undo "1"th "Repayment" transaction made on … on Working Capital loan) says the intent explicitly and is immune to insertion-order changes.
…-off loan should correct realized income e2e tests
…discount fee adjustment on a re-charged-off loan should correct realized income e2e tests
798a5d1 to
51c420b
Compare
|
@adamsaghy I fixed all issues:
|
Backdated discount fee adjustment on a re-charged-off loan should correct realized income
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.