feat: add deletion vector compaction planner - #918
Draft
wirybeaver wants to merge 3 commits into
Draft
Conversation
This was referenced Sep 5, 2026
wirybeaver
force-pushed
the
feature/dv-compaction-planner
branch
from
September 5, 2026 22:32
f05db6b to
0399008
Compare
Add a snapshot-bound metadata-only planner that selects rewrite candidates by file size and deduplicated file-scoped position-delete pressure. Validate planner inputs and group candidates deterministically within partitions using target-sized groups.
wirybeaver
force-pushed
the
feature/dv-compaction-planner
branch
from
September 5, 2026 23:56
0399008 to
56ed503
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompactionPlannerwithout rewrite executionINT64_MAXsize and delete-ratio thresholds without lossy integer-to-double conversiontarget_file_size_bytesAPI for Ticket 08
CompactionPlanner::Plan(int64_t source_snapshot_id, scan_tasks, config)CompactionPlan::source_snapshot_idrecords the snapshot used to produce the scan tasksThis PR is stacked on #913 and #915. Until those dependencies merge, it contains their prerequisite commits; review commit
56ed503for Ticket 07 itself. This replaces Ticket 07 commit03990086(which had already replacedf05db6b), and Ticket 08 must synchronize to56ed50369dcdfedd7af5962493ecfc33af0420af.Part of #916.
Test Plan
cmake --build build --target compaction_planner_test util_test -j2ctest --test-dir build -R "^(compaction_planner_test|util_test)$" --output-on-failure(2/2 passed)INT64_MAXcomparisons, oversized files, partition isolation, small files, target-sized grouping, and best-fit60,60,40,40packing/home/user/.cache/uv/archive-v0/1n0bbgciCQ9iE9BH/bin/pre-commit run --all-files(all hooks passed)git diff --check(passed)Revert Plan
Revert commit
56ed50369dcdfedd7af5962493ecfc33af0420afand restore the prior Ticket 07 dependency in downstream branches.