feat: add table-aware position delete updates - #919
Draft
wirybeaver wants to merge 4 commits into
Draft
Conversation
wirybeaver
force-pushed
the
feature/v3-dv-write-pipeline
branch
from
September 5, 2026 21:59
e6db958 to
c11cea2
Compare
wirybeaver
force-pushed
the
feature/v3-dv-write-pipeline
branch
from
September 5, 2026 22:21
c11cea2 to
477a2ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PositionDeleteUpdateAPI that resolves live data-file spec and partition metadata from the current snapshotRowDeltaCommitStateUnknownTracks #916.
Dependencies
Depends on #913, #914, and #915. This draft is stacked on their prerequisite commits and should be reviewed and merged after those PRs.
Test plan
./build/src/iceberg/test/data_test— 180 tests passed./build/src/iceberg/test/table_update_test --gtest_filter='RowDeltaTest.*'— 15 tests passedbuild/precommit-venv/bin/pre-commit run --files src/iceberg/data/position_delete_update.cc src/iceberg/test/position_delete_update_test.cc— all hooks passedFocused coverage includes descending v2 input with physical Parquet row-order verification, v2 file-scoped Parquet delete migration to a merged v3 DV, deterministic failure cleanup, ordinary commit retry reuse, and terminal output ownership after
CommitStateUnknown. Cleanup-failure coverage verifies that the deletion failure is appended to the original commit error, ownership is retained for the undeleted path, and a later attempt deletes the retained orphan before writing and committing new output.Remaining test limitation
The pipeline now opts into
ValidateDataFilesExist(...).ValidateDeletedFiles(), and the focusedRowDeltaTestvalidation suite passes. A deterministicPositionDeleteUpdatetest that injects a persisted v3 rewrite/removal between DV write and retry validation is not included: the retry/replay boundary is internal toTransaction/RowDelta, and the current catalog mock seam proceeds to another catalog attempt rather than exposing a stable validation hook. Covering that exact interleaving would require broader transaction test infrastructure outside this ticket.