Register to_bytes for UnknownType - #3899
Open
rambleraptor wants to merge 1 commit into
Open
Conversation
`from_bytes` and `partition_to_py` both handle `UnknownType`, but `to_bytes` did not, so serializing an unknown value fell through to the dispatch fallback and raised. Unknown values are always null and have no binary representation, so return None, matching `Conversions.toByteBuffer` in the Java implementation. The JSON single-value entry points are deliberately left unregistered: the spec defines no JSON representation for unknown, since a non-null initial-default or write-default is invalid for the type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
from_bytesandpartition_to_pyboth handleUnknownType, butto_bytesdid not.Are these changes tested?
Just added unit tests
Are there any user-facing changes?