Skip to content

Point agents at the Iceberg spec and Java reference implementation - #4426

Open
Fokko wants to merge 2 commits into
apache:mainfrom
Fokko:agents-spec-compliance
Open

Fokko wants to merge 2 commits into
apache:mainfrom
Fokko:agents-spec-compliance

Conversation

@Fokko

@Fokko Fokko commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

Agents had no instruction to validate behavior against the spec, or to fall back to the Java implementation where the spec is ambiguous.

Are these changes tested?

Are there any user-facing changes?

Agents had no instruction to validate behavior against the spec, or to
fall back to the Java implementation where the spec is ambiguous.
Comment thread AGENTS.md Outdated

### Spec Compliance

<!-- markdown-link-check-disable-next-line -->

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for disabling the Markdown link checker?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, there's no need for it here. The link-check comments are meant for the docs site, and these are stable GitHub URLs that the checker should cover. I've removed them.

Comment thread AGENTS.md
### Spec Compliance

<!-- markdown-link-check-disable-next-line -->
- The [Iceberg spec](https://github.com/apache/iceberg/blob/main/format/spec.md) is the source of truth. Check changes to metadata, manifests, schemas, partitioning, transforms, or the commit path against it, and cite the relevant section when behavior is non-obvious.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could potentially make that list larger (include work involving the catalogs?) and maybe even just tell the agents to always look at the Java reference implementation for any changes.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I've broadened the Java bullet so it covers every change, including catalog work. I also added a bullet pointing REST catalog changes (pyiceberg/catalog/rest/) at the REST catalog OpenAPI spec.

… guidance

Co-authored-by: Isaac <no-reply@databricks.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants