Repository navigation
fix: handle upserts after adding a column - #4444
Draft
ViktorBystrov72 wants to merge 1 commit into
Draft
ViktorBystrov72 wants to merge 1 commit into
ViktorBystrov72 wants to merge 1 commit into
Conversation
Co-authored-by: gpt-6.2-sol <noreply@openai.com>
Contributor
|
@ViktorBystrov72 Thanks for raising this PR, could you update the PR description te English? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3105
What changes are included in this PR?
During
upsert, read the selected snapshot using the current field types and match incoming fields by Iceberg field ID, including nested fields. This supports adding nullable fields, renaming fields and dropping and re-adding a field with the same name. Writes use the original incoming rows.Are these changes tested?
35 tests in
test_upsert.pyand 25 schema compatibility and projection checks passed. The regression cases cover themainanddevbranches, key type widening, partial schemas and field ID changes. Ruff,git diff --checkand the GitHub CI checks passed.AI Disclosure
Codex (gpt-6.2-sol) assisted with the implementation and tests. A separate local review checked snapshot projection and ID-based comparisons. This PR is a draft pending the author's review of nested-value comparisons and default handling.