Repository navigation
API, Core: DataFile and ManifestFile to expose column files via adapter - #17127
Open
gaborkaszab wants to merge 1 commit into
Open
gaborkaszab wants to merge 1 commit into
gaborkaszab wants to merge 1 commit into
Conversation
gaborkaszab
commented
Jul 7, 2026
| return null; | ||
| } | ||
|
|
||
| default List<ColumnFile> columnFiles() { |
Contributor
Author
There was a problem hiding this comment.
equalityFieldIds override the function from ContentFile. Following the same pattern, should columnFiles be also defined there?
gaborkaszab
commented
Jul 7, 2026
|
|
||
| /** Information about a column file. */ | ||
| interface ColumnFile { | ||
| public interface ColumnFile { |
Contributor
Author
There was a problem hiding this comment.
To return List from DataFile, we have to move this class to API and make it public.
anuragmantri
self-requested a review
July 7, 2026 22:06
gaborkaszab
force-pushed
the
main_column_file_in_trackedfile_adapter
branch
2 times, most recently
from
August 6, 2026 09:40
772932c to
9909efc
Compare
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
gaborkaszab
force-pushed
the
main_column_file_in_trackedfile_adapter
branch
from
September 7, 2026 11:42
9909efc to
5a05561
Compare
gaborkaszab
force-pushed
the
main_column_file_in_trackedfile_adapter
branch
from
November 6, 2026 16:26
5a05561 to
4a300f5
Compare
gaborkaszab
force-pushed
the
main_column_file_in_trackedfile_adapter
branch
from
November 20, 2026 14:51
4a300f5 to
a6178b7
Compare
gaborkaszab
force-pushed
the
main_column_file_in_trackedfile_adapter
branch
from
November 20, 2026 15:01
a6178b7 to
2a850d9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.