Skip to content

API, Core: Add Snapshot.rootManifestLocation() - #17523

Merged
stevenzwu merged 4 commits into
apache:mainfrom
stevenzwu:snapshot_file_extract
Nov 13, 2026
Merged

stevenzwu merged 4 commits into
apache:mainfrom
stevenzwu:snapshot_file_extract

Conversation

@stevenzwu

@stevenzwu stevenzwu commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

v4 snapshots store a root-manifest instead of a manifest-list, so Snapshot needs to expose that location. This adds Snapshot.rootManifestLocation() defaulting to null, parsed and written as root-manifest. manifestListLocation is unchanged for v1-v3, and at most one of the two is set. Commits still write a manifest list and readers stay on manifestListLocation until a root manifest write path exists. The snapshots metadata table column and the encryption abstraction were removed from this PR.

Test plan: TestSnapshotJson and TestMetadataUpdateParser round-trips for root-manifest.

AI assisted.

@stevenzwu
stevenzwu force-pushed the snapshot_file_extract branch 3 times, most recently from 51e06e3 to ee6b97b Compare August 5, 2026 04:12
@stevenzwu
stevenzwu force-pushed the snapshot_file_extract branch from ee6b97b to 0073109 Compare August 6, 2026 05:44
@stevenzwu
stevenzwu force-pushed the snapshot_file_extract branch from 0073109 to 63c4057 Compare August 6, 2026 06:00

@gaborkaszab gaborkaszab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping this rolling, @stevenzwu !
I have 2 comments in general:

  1. I think I'd not include metadata tables to this PR. That seems an orthogonal question and can be a follow-up and a different discussion how to visualize this abstraction
  2. For me the abstraction layer we introduce here is too specific. I describe this in multiple of my comments, but basically we could simplify encryption APIs if we introduced a more general abstraction here that goes for every file that keeps it's encrypted encryption keys in TableMetadata.encryptionKeys, including TableStataistics and PartitionStatistics (see this for the former)

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions Bot added the stale label Sep 7, 2026
@stevenzwu
stevenzwu force-pushed the snapshot_file_extract branch 4 times, most recently from 81159ce to c9b805a Compare September 10, 2026 23:10
@stevenzwu stevenzwu changed the title API, Core, Spark, Flink: extract SnapshotFile abstraction API, Core, Spark, Flink: add version-agnostic Snapshot.rootLocation() Sep 10, 2026
@stevenzwu
stevenzwu force-pushed the snapshot_file_extract branch 3 times, most recently from 89ffa8e to 9b1909b Compare September 11, 2026 04:24
@github-actions github-actions Bot removed the stale label Sep 12, 2026
@github-actions

Copy link
Copy Markdown

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions Bot added the stale label Oct 12, 2026
@github-actions

Copy link
Copy Markdown

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions Bot closed this Oct 20, 2026
@stevenzwu stevenzwu changed the title API, Core, Spark, Flink: add Snapshot.rootManifestLocation() API, Core, Spark: add Snapshot.rootManifestLocation() Nov 2, 2026
@stevenzwu
stevenzwu force-pushed the snapshot_file_extract branch 2 times, most recently from d1c11ad to 5de0a95 Compare November 3, 2026 05:56
for (Snapshot snapshot : metadata.snapshots()) {
String newManifestListLocation =
newPath(snapshot.manifestListLocation(), sourcePrefix, targetPrefix);
String manifestList = snapshot.manifestListLocation();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also need to handle ReachableFileCleanup and IncrementalFileCleanup?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep that out of this PR since nothing writes root manifests yet. Both cleanup paths read through allManifests, which now throws UnsupportedOperationException for root-manifest snapshots, so they fail loudly instead of silently skipping files.

TableMetadata metadata, String sourcePrefix, String targetPrefix) {
List<Snapshot> newSnapshots = Lists.newArrayListWithCapacity(metadata.snapshots().size());
for (Snapshot snapshot : metadata.snapshots()) {
String newManifestListLocation =

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few more places in this class that reference snapshot.manifestListLocation() directly, should we update those as well?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that is necessary. This is updating this method to fulfill its contract, not going down the rabbit hole of making relocation work in v4.

@gaborkaszab

gaborkaszab commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

I haven't been looking into this for a long time, but do we still need to make #17545 a dependency of this one? As I see we made the RootManifestFile dependent on ManifestFile that goes against the intent of the "generic common parent" of V3 manifest list file and V4 root manifest file.
Also by the title this PR seems to focus on a common root location that seems a narrower problem.

@gaborkaszab gaborkaszab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I wasn't active on this PR for a while. I think the scope has change in the meantime, got narrowed to simply introducing the new root-manifest field. Left some comments with this in mind.

Also, just a thought on the direct follow-ups: There are a handful of new fields introduced for V4 snapshots. This PR introduces a single one of them. Shouldn't we do them in bulk by a single PR?

keyId);
}

BaseSnapshot(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these constructors asymmetric? We have now a variation that accepts manifest list only, and another one that accepts both manifest list and root manifest. To restore symmetry, we either need a third one accepting root manifest only, or simply having the one that accepts both without the other 2 variations. I would personally go for the second option.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went with your recommendation and modify the existing constructor directly.

Iterables.transform(snapshot.allManifests(DUMMY_FILE_IO), ManifestFile::path),
generator);
String rootManifest = snapshot.rootManifestLocation();
if (rootManifest != null) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an "if - else { if - else}" structure. I think we can use a cleaner "if - else if - else" non-nested structure by adding String rootManifest = snapshot.rootManifestLocation() above the if.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. toJson now reads both locations up front and uses a flat if / else if / else.

String rootManifest = snapshot.rootManifestLocation();
if (rootManifest != null) {
generator.writeStringField(ROOT_MANIFEST, rootManifest);
} else {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the order of the checks is off. Previously we did "if not V2 then V1". Shouldn't we check V3 root manifest first, then V2 manifest list, then V1?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. The order is now root-manifest first, then manifest-list, then the embedded v1 manifests.


if (manifestList != null || rootManifest != null) {
// manifest-list is used by v1-v3 snapshots, root-manifest by v4 snapshots
return new BaseSnapshot(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems another reason why we should drop the manifest list only constructor.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, with the list-only constructor gone, fromJson now has a single call that passes both manifestList and rootManifest. The v1 embedded-manifests constructor is still separate.

6,
"summary",
Types.MapType.ofRequired(7, 8, Types.StringType.get(), Types.StringType.get())));
Types.MapType.ofRequired(7, 8, Types.StringType.get(), Types.StringType.get())),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall @rdblue is in favor of not implementing metadata table support right away as we might want to re-consider how they should look like in V4.
I know I've commented before not to add coverage for metadata table in this PR, and I still think this way.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I removed the snapshots metadata table changes from this PR. We can decide how v4 should show up in metadata tables in a separate discussion.

FileFormat.AVRO, fileIO.newInputFile(snapshot.manifestListLocation()))
FileFormat.AVRO,
ManifestLists.newInputFile(
fileIO, new BaseFileWithEncryptedKey(location, null, snapshot.keyId(), null)))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure about the scope of this PR now. Based on the title I have the impression that we introduce support for the new root-manifest field to Snapshot and its parsers. Here we also do some other stuff:

  1. Route InputFile creation through the caching ManifestLists path.
  2. Introduce the more generic abstraction of ManifestListFile in order to be able to call ManifestLists.newInputFile.

Currently, I don't think that any of the above is the scope of this PR. Then we could remove the dependency on #17545 too.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on the scope. I removed the FileCleanupStrategy change and the ManifestLists routing, so this PR no longer depends on #17545. It now only adds the root-manifest field to Snapshot, BaseSnapshot, and SnapshotParser, plus the path rewrite in RewriteTablePathUtil.

anoopj added a commit to anoopj/iceberg that referenced this pull request Nov 11, 2026
When the selected snapshot references a Parquet root manifest, plan the scan through the native FilePlanner instead of the manifest-list ManifestGroup path. DataTableScan and BaseDistributedDataScan gate on root-manifest presence via a shared SnapshotScan.planV4RootManifest helper, so manifest-list snapshots (v1-v3 and those retained across an upgrade) are unaffected. RootManifestFile.from resolves the root against the table location; column stats and manifest-scan metrics are forwarded; unsupported entries (encrypted roots, column files, pre-v4 delete manifests) are rejected when encountered.

Stacked on the preceding cherry-picked commit "API, Core: Add v4 root manifest location to Snapshot" (duplicated from apache#17523 to unblock the read path); drop it once apache#17523 merges on its own.
anoopj added a commit to anoopj/iceberg that referenced this pull request Nov 11, 2026
V4 snapshots reference a single root manifest instead of a manifest list (spec change in apache#16025). Add Snapshot.rootManifestLocation() and serialize it as the "root-manifest" field, keeping manifestListLocation() and "manifest-list" for v1 through v3. BaseSnapshot stores the location and does not support reading manifests from a root manifest until the reader lands.

Root-manifest snapshots are built through BaseSnapshot.withRootManifest(), which requires an operation, a first-row-id, and a sequence number greater than 0; keeping manifest-list and root-manifest construction on separate paths makes setting both impossible. SnapshotParser rejects a root-manifest snapshot that also sets a manifest list or is missing sequence-number, summary, summary.operation, first-row-id, or added-rows. The v1 through v3 fallback that defaults a missing operation to overwrite is preserved for manifest-list snapshots and skipped for root-manifest snapshots, which require an operation.

Producing a root manifest, reading one, and updating the manifest-list-centric callers (expire and cleanup, metadata tables, RewriteTablePath) are deferred to the root manifest reader and writer, which are not yet in the tree.

This duplicates the standalone rootManifestLocation change from apache#17523 (currently stacked on encryption PR apache#17545). It is included here only to unblock the v4 read path and should be rebased/dropped once apache#17523 lands on its own.

Spec PR: apache#16025

(cherry picked from commit 02eb1329e21d06f8ed8acb5702702a180a0a9051)
anoopj added a commit to anoopj/iceberg that referenced this pull request Nov 11, 2026
Route a data scan to the v4 `FilePlanner` when the selected snapshot
references a root manifest.

Stacked on a cherry-picked commit from apache#17523
anoopj added a commit to anoopj/iceberg that referenced this pull request Nov 11, 2026
v4 snapshots store their root file in "root-manifest" instead of
"manifest-list". Add Snapshot.rootManifestLocation() and serialize it as the
"root-manifest" JSON field, keeping manifestListLocation() and "manifest-list"
for v1 through v3. Each snapshot sets exactly one of the two.

Read-path subset of apache#17523 (commit 5de0a95), excluding its
encryption dependency and the manifest-list-centric callers (metadata tables,
cleanup, RewriteTablePath) plus the engine and doc changes the read path does
not need.

(cherry picked from commit 5de0a95)
anoopj added a commit to anoopj/iceberg that referenced this pull request Nov 11, 2026
Route a data scan to the v4 `FilePlanner` when the selected snapshot
references a root manifest.

Stacked on a cherry-picked commit from apache#17523
v4 snapshot metadata has no format-version field and stores the snapshot's
root file in root-manifest instead of manifest-list. Add
Snapshot.rootManifestLocation() and keep manifestListLocation() for v1-v3
snapshots. Each snapshot sets at most one of the two.

Commits still write a manifest list. Readers that open the snapshot file as
a manifest list stay on manifestListLocation() until a root manifest is written.

Generated-by: Cursor Grok 4.7
Co-authored-by: Cursor <cursoragent@cursor.com>
Iterables.transform(snapshot.allManifests(DUMMY_FILE_IO), ManifestFile::path),
generator);
String rootManifest = snapshot.rootManifestLocation();
if (rootManifest != null) {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. toJson now reads both locations up front and uses a flat if / else if / else.

String rootManifest = snapshot.rootManifestLocation();
if (rootManifest != null) {
generator.writeStringField(ROOT_MANIFEST, rootManifest);
} else {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. The order is now root-manifest first, then manifest-list, then the embedded v1 manifests.


if (manifestList != null || rootManifest != null) {
// manifest-list is used by v1-v3 snapshots, root-manifest by v4 snapshots
return new BaseSnapshot(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, with the list-only constructor gone, fromJson now has a single call that passes both manifestList and rootManifest. The v1 embedded-manifests constructor is still separate.

6,
"summary",
Types.MapType.ofRequired(7, 8, Types.StringType.get(), Types.StringType.get())));
Types.MapType.ofRequired(7, 8, Types.StringType.get(), Types.StringType.get())),

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I removed the snapshots metadata table changes from this PR. We can decide how v4 should show up in metadata tables in a separate discussion.

FileFormat.AVRO, fileIO.newInputFile(snapshot.manifestListLocation()))
FileFormat.AVRO,
ManifestLists.newInputFile(
fileIO, new BaseFileWithEncryptedKey(location, null, snapshot.keyId(), null)))

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on the scope. I removed the FileCleanupStrategy change and the ManifestLists routing, so this PR no longer depends on #17545. It now only adds the root-manifest field to Snapshot, BaseSnapshot, and SnapshotParser, plus the path rewrite in RewriteTablePathUtil.

Map<String, String> summary,
Integer schemaId,
String manifestList,
String rootManifest,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed @gaborkaszab 's suggestion and dropped the list-only overload, keeping a single constructor that takes both locations. Existing callers pass null for rootManifest.

The upside is a single signature. The downside is every previous list-only call site now passes an extra null, which leads to churning in test code.

This is how BaseSnapshot has grown before: schemaId (#2275), firstRowId/addedRows (#11948), and keyId (#12927) were added to the same constructor.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to introduce a dedicated contract once all the other V4 Snapshot fields are introduced, but let it be the concert of the follow-ups, not this one.
Thanks!

keyId);
}

BaseSnapshot(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went with your recommendation and modify the existing constructor directly.

@stevenzwu

Copy link
Copy Markdown
Contributor Author

Also, just a thought on the direct follow-ups: There are a handful of new fields introduced for V4 snapshots. This PR introduces a single one of them. Shouldn't we do them in bulk by a single PR?

@gaborkaszab I would separate them out. this can get in first to unblock @anoopj

* Return the location of this snapshot's root manifest, or null if this snapshot has no root
* manifest.
*
* <p>v4 snapshots store this in {@code root-manifest} instead of a manifest list. At most one of

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"At most one of this..." reads a bit confusing. Maybe just say something like "Snapshots in v1-v3 use {@link #manifestListLocation()} instead"?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed that paragraph. The first sentence now describes the null case directly.

null /* summary */,
1 /* schemaId */,
"ml.avro" /* manifestListLocation */,
null /* rootManifest */,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should maybe have a test in this class where root manifest is set

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests for a root-manifest snapshot covering the both/neither validation and allManifests rejecting root manifests.

snapshot.schemaId(),
newManifestListLocation,
manifestList == null ? null : newPath(manifestList, sourcePrefix, targetPrefix),
rootManifest == null ? null : newPath(rootManifest, sourcePrefix, targetPrefix),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably have a test in TestRewriteTablePathUtil that makes sure the root manifest is rewritten to the new location

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added replacePathsRewritesRootManifestLocation, which asserts the rewritten location.

@gaborkaszab gaborkaszab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevenzwu !

Map<String, String> summary,
Integer schemaId,
String manifestList,
String rootManifest,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to introduce a dedicated contract once all the other V4 Snapshot fields are introduced, but let it be the concert of the follow-ups, not this one.
Thanks!

for (Snapshot snapshot : metadata.snapshots()) {
String newManifestListLocation =
newPath(snapshot.manifestListLocation(), sourcePrefix, targetPrefix);
String manifestList = snapshot.manifestListLocation();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're introducing the new field to Snapshot, I don't think that we should implement table rewrite functionality right away. Could that be separate?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's reasonable to include this. This behavior is correct for this method's contract. We don't need to make the whole table rewrite work, but where we can update methods to fully implement their guarantees it seems like a good idea.


assertThat(snapshot.snapshotId()).isEqualTo(expected.snapshotId());
assertThat(snapshot.manifestListLocation()).isEqualTo(expected.manifestListLocation());
assertThat(snapshot.rootManifestLocation()).isEqualTo(expected.rootManifestLocation());

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what coverage we add with these asserts on rootManifestLocation, because they are always null, except in one dedicated test. Should we assert isNull() as we do with other fields below?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@rdblue rdblue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine overall. I think @nastra's request for a test for RewriteTablePathUtil is reasonable.

for (Snapshot snapshot : metadata.snapshots()) {
String newManifestListLocation =
newPath(snapshot.manifestListLocation(), sourcePrefix, targetPrefix);
String manifestList = snapshot.manifestListLocation();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's reasonable to include this. This behavior is correct for this method's contract. We don't need to make the whole table rewrite work, but where we can update methods to fully implement their guarantees it seems like a good idea.

TableMetadata metadata, String sourcePrefix, String targetPrefix) {
List<Snapshot> newSnapshots = Lists.newArrayListWithCapacity(metadata.snapshots().size());
for (Snapshot snapshot : metadata.snapshots()) {
String newManifestListLocation =

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that is necessary. This is updating this method to fulfill its contract, not going down the rabbit hole of making relocation work in v4.

summary(base),
base.currentSchemaId(),
manifestList.location(),
null /* rootManifest */,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This is not going to be re-wrapped, so I think there isn't a reason to use an inline comment instead of a line comment.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, now a line comment: null, // rootManifest

stevenzwu and others added 2 commits November 12, 2026 15:36
A snapshot must have exactly one of manifest-list or root-manifest.
Reject reading manifests from a root-manifest snapshot until that
path is implemented.

Generated-by: Cursor
Co-authored-by: Cursor <cursoragent@cursor.com>
The manifestListLocation() Javadoc should say when the value is null
without referring to whether the list is separate. Also tidy the
allManifests comment and the SnapshotProducer root manifest argument
so they describe the current code.

Generated-by: Cursor
Co-authored-by: Cursor <cursoragent@cursor.com>
@rdblue

rdblue commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Looks like all of the comments were addressed so I'll merge this when tests are passing to unblock @anoopj and other work. Thanks, @stevenzwu!

Test fixtures used full s3 URIs for root manifests while the rest of the
snapshot tests use relative names. Keep the URIs only where the test
rewrites locations between prefixes.

Generated-by: Cursor
Co-authored-by: Cursor <cursoragent@cursor.com>
@stevenzwu

Copy link
Copy Markdown
Contributor Author

CI passed. I merged this one.

Thanks @gaborkaszab @nastra @rdblue @amogh-jahagirdar @anoopj for the reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants