Repository navigation
Core: Avoid file lookups when sizing static metadata tasks - #18467
Open
eholmer-pltr wants to merge 2 commits into
Open
eholmer-pltr wants to merge 2 commits into
eholmer-pltr wants to merge 2 commits into
Conversation
Estimate static task sizes from their in-memory rows while preserving location identity and correct row-count estimates. Generated-by: Codex
Generated-by: Codex
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
Author
|
@danielcweeks / @dhruvarya-db based on the proposal here #17642 and in particular https://github.com/apache/iceberg/pull/17642/changes#diff-ffc6f59bffb61af69bc4ef19c7b28c9fefe015b2716b35db1deb6a5a884ca4feR2019-R2020 this seems like an obvious (but trivial) blocker |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static metadata-table tasks currently stat their backing metadata files solely to populate a synthetic file size, even though their rows are already materialized. Pass the location directly and estimate task size from the full row schema and row count, preserving file identity and useful planning statistics without that lookup. Nonempty tasks retain a positive size so their inherited row-count estimates remain correct. Supersedes #16833 and closes #18465.
AI Disclosure