Skip to content

Spec: List identity and bucket source types explicitly - #18545

Merged
stevenzwu merged 1 commit into
mainfrom
spec/explicit-transform-source-types
Nov 21, 2026
Merged

stevenzwu merged 1 commit into
mainfrom
spec/explicit-transform-source-types

Conversation

@stevenzwu

@stevenzwu stevenzwu commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Identity in the table spec accepts any primitive except geometry and geography, so a newly added primitive becomes a valid identity source without an explicit decision. Bucket in that table is already an allowlist. The expressions spec still describes both transforms with exception lists, and its bucket rule is broader than the table spec. This lists the source types explicitly in both specs and makes the expressions spec use the table spec's bucket allowlist.

Follow-up to the discussion on #18416 (comment)

Made with Cursor

New primitive types should not silently become identity sources, and the
expressions spec must use the same source-type lists as the table spec.

Generated-by: Cursor (Grok 4.7)
@github-actions github-actions Bot added the Specification Issues that may introduce spec changes. label Oct 16, 2026
@stevenzwu

Copy link
Copy Markdown
Contributor Author

if we don't agree with identity transform change (exclusion list -> inclusion list), we should at least update the bucket transform in the expression spec (exclusion list) to align with the table spec (inclusion list)

@RussellSpitzer RussellSpitzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, I also suggested we probably just define this as another sub group (not primitive) something like "Simple Types" or whatever.

@huaxingao

Copy link
Copy Markdown
Contributor

I think the allowlist is better: a new primitive type is not a valid identity or bucket source until someone adds it on purpose. vector in #18416 is the first case. Without this, identity(vector) would be allowed by default.

@stevenzwu
stevenzwu merged commit 0ff724d into main Nov 21, 2026
10 checks passed
@stevenzwu
stevenzwu deleted the spec/explicit-transform-source-types branch November 21, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Specification Issues that may introduce spec changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants