Repository navigation
Nessie: Return false for table and view drop type mismatches - #18912
binarybrain-009 wants to merge 3 commits into
Conversation
Move both purge cases into ViewCatalogTests. Hive, JDBC, in-memory and REST pass; temporarily disable the inherited Nessie case pending the separate fix in apache#18912. Generated-by: Codex
|
human review please |
|
@pvary I've personally reviewed the fix and regression test, and updated the human-review disclosure. This is ready for another look. Thanks! |
binarybrain-009
left a comment
There was a problem hiding this comment.
Reviewed byhuman
|
@pvary Applied your suggestion in 439a6f4: missing content or either type mismatch now returns false before deletion. Added a regression for dropView at a table identifier that loads the surviving table and checks its UUID. It failed on both Nessie API versions before the change; the full Nessie build and tests now pass, including both mismatch directions. Could you take another look? These latest follow-ups were generated with Codex and are marked as awaiting my personal review in the disclosure. |
|
Addrexsed all the review comments and reviewed as a human |
|
Pls rebase @binarybrain-009 |
A view identifier does not identify a table. Preserve the view and return false for either purge setting instead of throwing a type-mismatch exception. Generated-by: Codex
Generated-by: Codex
439a6f4 to
30bf122
Compare
|
Please drop the extra tests, and update the PR description. |
Remove duplicate Nessie tests now that the inherited ViewCatalogTests cover both mismatch directions. Generated-by: Codex
|
Addressed the comments and reviewed as a human |
NessieCatalog.dropTablethrows when the identifier belongs to an Iceberg view, anddropViewthrows when it belongs to an Iceberg table. Returnfalsefor either type mismatch before attempting deletion, matching the catalog contracts. Re-enable the sharedViewCatalogTestscases introduced by #18691 by removing Nessie's temporary disabled overrides.Test plan: Run the inherited mismatch tests against both Nessie API versions. They verify that dropping a table at a view identifier (with either purge setting), or a view at a table identifier, returns
falseand preserves the existing object's UUID. The full Nessie build, tests, formatting and checkstyle checks pass.AI Disclosure