Repository navigation
Conversation
jakarta-el-api in iceberg-nessie is always overridden by the version the Nessie test extension pulls in, and hadoop-hdfs in the Flink modules already arrives through hadoop-minicluster. The aliyun OSS mock only needs jackson-databind, not jackson-dataformat-xml. Generated-by: Claude Code Co-authored-by: Isaac <no-reply@databricks.com>
Fokko
commented
Nov 20, 2026
Comment on lines
-1066
to
-1067
| // Need to "pull in" el-api explicitly :( | ||
| testImplementation libs.jakarta.el.api |
Contributor
Author
There was a problem hiding this comment.
Why it's no longer needed: with Nessie 0.110.0, dependencyInsight shows jakarta.el-api arriving through two paths:
- nessie-jaxrs-testextension → weld-se-core → weld-core-impl 6.0.4, which requests 6.0.1.
- jersey-test-framework-provider-bundle 4.0.3, which requests 5.0.1.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes test dependency declarations that have no effect: jakarta-el-api in iceberg-nessie, which the Nessie test extension already overrides with a newer version, and hadoop-hdfs in the Flink modules, which hadoop-minicluster already brings in. In iceberg-aliyun, jackson-dataformat-xml is replaced by jackson-databind, which is all the OSS mock uses.
AI Disclosure
This pull request and its description were written by Isaac.