Repository navigation
Conversation
Author
|
Closing this, the fix is now folded into #19048 per review discussion there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #19048, as @ebyhr pointed out in the review there.
Background
GCSInputStream.readTail()looks up the blob size withstorage.get(blobId).getSize()when the length isn't known.Storage.get(BlobId)returnsnullfor a missing object, so reading the tail of a deleted file throws an NPE instead of aNotFoundException. The channel reads already map 404s toNotFoundExceptionviaGCSExceptionUtil(#15734), but this lookup happens before any channel is opened.Fix
If the blob is missing, throw
NotFoundException("Location does not exist: %s", blobId.toGsUtilUri()), same message asGCSExceptionUtil. A known length still skips the lookup.Tests
TestGCSInputStream#readTailMissingBlob:readTailon a blob that doesn't exist (withLocalStorageHelper) throwsNotFoundExceptionwith the location. It fails with the NPE when the fix is reverted../gradlew :iceberg-gcp:testand:iceberg-gcp:spotlessCheckpass locally (JDK 21).AI disclosure: I used an AI assistant (Claude Opus 5.5) to help write this change and the test. I reviewed the code and ran the tests myself.