Repository navigation
API, Core: Revert reading geo bounds as GeospatialBound (#18394) - #19070
Merged
Merged
Conversation
stevenzwu
force-pushed
the
revert-geospatial-bound-read
branch
2 times, most recently
from
November 20, 2026 19:38
a5e0325 to
e7adc4b
Compare
huaxingao
approved these changes
Nov 20, 2026
…pache#18394)" This reverts commit ea47af3. Generated-by: Cursor (Claude Opus 5.5)
stevenzwu
force-pushed
the
revert-geospatial-bound-read
branch
from
November 20, 2026 23:20
e7adc4b to
3d24636
Compare
rdblue
reviewed
Nov 20, 2026
| * deserialization of these bounds to/from byte arrays, conforming to the Iceberg specification. | ||
| */ | ||
| public class GeospatialBound implements StructLike, Serializable { | ||
| public class GeospatialBound implements StructLike { |
Contributor
There was a problem hiding this comment.
Do we still want Serializable?
rdblue
approved these changes
Nov 20, 2026
rdblue
left a comment
Contributor
There was a problem hiding this comment.
Look good to me. Thanks, @stevenzwu!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a
git revertof ea47af3 from #18394 with one manual conflict resolution inTestV4ManifestReader. #18598 later removed thefalsetight-stats argument from thenew FieldStatsStruct<>(...)call in thegeoFieldStatshelper that #18394 added. The whole helper is removed in the revert.#18394 reads geo bounds as
GeospatialBound. Readers fill custom structs by position, so projecting a subset of the coordinates, for example onlylower_bound.m, stored M as X (discussion). #18394 worked around this by always projecting the full geo bound struct, which reads columns the caller didn't request. @rdblue recommended offline that Iceberg shouldn't project additional data like the entire bound.The spec says that if either the X or Y dimension is missing, the bounding box is not produced.
GeospatialBoundrepresents a bounding-box corner and should guarantee valid X and Y, so it shouldn't represent a partially projected bound. Making it projection-aware would also add a mutableStructLikewith stats schema knowledge to the api module.After this revert:
GeospatialBoundkeeps the read-onlyStructLikethe writer uses.The trade-off is that the two paths aren't symmetric: writes take a
GeospatialBound, and reads return a generic struct.Follow-up:
ContentStatsBackedMapreads the bound struct by fixed position.GeospatialBoundStructin core module that extendsSupportsIndexProjectionAI assisted conflict resolution.