Conversation
When TransformPathFlatten/TransformPathFlattenAlgebra run they expand
some paths of the form :x :p{N,M} ?y into multiple triple patterns
within a BGP e.g. :x :p ?q0 . ?q0 :p ?y etc. This is safe for short
values of M but can result in extremely large expansions if M is a large
value. The large expansion is unlikely to make the query run any faster
and a sufficiently large value can cause the query optimiser to fail with
memory/stack issues. This commit introduces a new static control for
the maximum expansion length capped at 10 and does not apply full
expansion to anything longer than that.
Member
|
I agree with the intent. just checking here but I think you mean Unless there is evidence to the contrary, maybe the limit ( |
Member
Author
Yes sorry, got the terminology confused
Yeah I think that's probably sensible, can adjust the PR accordingly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
TransformPathFlattern/TransformPathFlattenAlgebrarun they expand some paths of the form:x :p{N,M} ?yinto multiple triple patterns within a BGP e.g.:x :p ?q0 . ?q0 :p ?yetc. This is safe for short values ofMbut can result in extremely large expansions ifMis a large value. The large expansion is unlikely to make the query run any faster. This commit introduces a new static control for the maximum expansion length capped at10and does not apply full expansion to anything longer than that.By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.