GH-4230: Preserve declared layout of nested WKT collections in geometryN - #4262
Open
edmondchuc wants to merge 1 commit into
Open
edmondchuc wants to merge 1 commit into
edmondchuc wants to merge 1 commit into
Conversation
edmondchuc
force-pushed
the
fix/geosparql/geometry-n-nested-layout
branch
from
September 27, 2026 13:21
66ff676 to
193d6b1
Compare
…geometryN Previously, declared coordinate layout was only stashed in userData for empty aggregates. In DimensionInfo.find, inspecting the first member took precedence over userData. Consequently, selecting a nested collection with heterogeneous children (e.g., GEOMETRYCOLLECTION M containing a Point Z) caused the collection to inherit its first child's coordinate layout rather than preserving its own declared layout. Retain the declared coordinate layout on all aggregates during WKT parsing, and prioritize this retained layout over the first-member fallback in DimensionInfo.find. Add tests for nested collections with XY, M, Z, and ZM markers through geometryN selection and WKT round trips.
edmondchuc
force-pushed
the
fix/geosparql/geometry-n-nested-layout
branch
from
September 27, 2026 13:30
193d6b1 to
cd919e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4230
Selecting a nested WKT GeometryCollection with mixed member layouts could replace the collection’s declared XY, Z, M, or ZM layout with that of its first member. This change preserves the declared layout when selecting a member with
geof:geometryNand when writing the result back to WKT.By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.