Repository navigation
Conversation
f9af168 to
db15896
Compare
potiuk
left a comment
There was a problem hiding this comment.
Thanks for wiring the Discord adapter from #1484 into the docs — the links to tools/chat-discord/ resolve once #1484 lands, and the stack is in order. Two things need fixing before this merges: a wrong tracking link in the adapter registry (inline), and spec text that now contradicts itself.
The contributor-growth spec now contradicts itself
The specs in
tools/spec-loop/specs/are the source of truth and must not fall behind the code.
—AGENTS.md
In tools/spec-loop/specs/contributor-growth.md the frontmatter source: and the Known-gaps bullet now say chat covers Slack and Discord, but two passages the diff doesn't touch still say otherwise:
- Where it lives → Tools bullet:
`tools/chat-slack` (Slack MCP adapter, public channels only, never posts). Discord is an extension point with no adapter yet. - Behaviour & contract → Community signals:
chat answers through `contract:chat` (Slack adapter; public channels only).
Please add tools/chat-discord (Discord MCP adapter, public channels only, never posts) to the Tools bullet, drop the "Discord is an extension point" sentence, and change "(Slack adapter; …)" to "(Slack or Discord adapter; …)".
Smaller observations
- See inline on
specs/adapters.mdand the project template (chat.guild_id). tools/chat/README.md→ Prerequisites → Credentials / auth still describes only the Slack connector; please add a clause for the Discord adapter.- The PR description lists
docs/labels-and-capabilities.mdchanges, but those are in #1484 — please correct it so the stack's descriptions match their contents. And consider "Closes #1421" on whichever stack PR lands last, so the adapter issue closes when the work ships. - Any change to #1484's coverage (see the review there) flows into the "shipping" wording here.
This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. After you've
addressed the points above and pushed an update, an Apache Magpie
maintainer — a real person — will take the next look
at the PR. The findings cite the project's review criteria;
if you think one of them is mis-applied, please reply on the
PR and a maintainer will weigh in.More on how Apache Magpie handles maintainer review:
CONTRIBUTING.md.
…pecs, and scorer test Address review feedback on PR #1485: - docs/adapters/registry.md: fix tracking issues for Matrix (#309) and Zulip (#308) - tools/spec-loop/specs/contributor-growth.md: list tools/chat-discord, remove extension point text, and note Slack or Discord in community signals - tools/spec-loop/specs/adapters.md: add tools/chat-discord/ to frontmatter, align Slack/Discord adapter wording, and move none placeholder to tools/chat/ - plugins/magpie-setup/templates/project.md: document chat.guild_id in summary table and yaml example - tools/chat/README.md: document chat.guild_id in yaml example and mention Discord bot token under $HOME in prerequisites - tools/vendor-neutrality-score/tests/test_vendor_neutrality_score.py: test live repository tools loaded from disk rather than synthetic objects Generated-by: Antigravity
d0c0a8e to
2caa40f
Compare
potiuk
left a comment
There was a problem hiding this comment.
Thanks — all three earlier threads, the contributor-growth spec contradictions, and the Credentials clause are fixed. Two small config-wording issues remain inline (guild_id shipping as an active "..." value, and "channel names or IDs" promised contract-wide while the Slack adapter resolves names only), plus a nit. Merge still waits on #1484.
The PR description still says this PR marks contract:chat vendor-neutral and moves the score to 11/12 — that change now lives in #1484; please refresh the description (and "taxonomy" in the title) to match what this PR contains.
This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The findings
below are observations, not blockers; an Apache Magpie
maintainer — a real person — will take the next look at the
PR. If you think a finding is mis-applied, please reply on
the PR and a maintainer will weigh in.More on how Apache Magpie handles maintainer review:
CONTRIBUTING.md.
…pecs, and scorer test Address review feedback on PR #1485: - docs/adapters/registry.md: fix tracking issues for Matrix (#309) and Zulip (#308) - tools/spec-loop/specs/contributor-growth.md: list tools/chat-discord, remove extension point text, and note Slack or Discord in community signals - tools/spec-loop/specs/adapters.md: add tools/chat-discord/ to frontmatter, align Slack/Discord adapter wording, and move none placeholder to tools/chat/ - plugins/magpie-setup/templates/project.md: document chat.guild_id in summary table and yaml example - tools/chat/README.md: document chat.guild_id in yaml example and mention Discord bot token under $HOME in prerequisites - tools/vendor-neutrality-score/tests/test_vendor_neutrality_score.py: test live repository tools loaded from disk rather than synthetic objects Generated-by: Antigravity
2caa40f to
8c6cc01
Compare
Integrate tools/chat-discord into the chat contract documentation, adapter registry, spec-loop specifications, and adopter project template. - In docs/adapters/registry.md: update tracking issues for Matrix (#309) and Zulip (#308). - In plugins/magpie-setup/templates/project.md and tools/chat/README.md: ship optional Discord-specific chat.guild_id commented out, clarify channel names as accepting IDs for Discord, and document Discord bot token under \C:\Users\arnav in prerequisites credentials. - In tools/spec-loop/specs/adapters.md and contributor-growth.md: list tools/chat-discord as a shipping adapter under contract:chat, note chat covers Slack and Discord while Matrix and Zulip remain extension points with no adapter yet. Generated-by: Antigravity
8c6cc01 to
2d83965
Compare
potiuk
left a comment
There was a problem hiding this comment.
Thanks — all three points from the last review are in (the commented-out guild_id in the template and the contract README, "channel names (Discord also accepts IDs)", and Matrix + Zulip in the contributor-growth spec), and the title and description now match what this PR contains. It's consistent with #1484's current head, so this is ready to land as soon as #1484 does.
This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Magpie handles maintainer review:
CONTRIBUTING.md.
Part 2 of 2 in the
contract:chatDiscord adapter stack (preceded by #1484).Summary
tools/chat-discordinto the chat contract documentation (tools/chat/README.md), markingdiscordas a shipping adapter alongsideslack.$HOME(~/.config/apache-magpie/discord-tokenor$DISCORD_BOT_TOKEN) intools/chat/README.mdprerequisites credentials.chat.guild_id(commented out by default) and clarifies channel names (with Discord IDs accepted) inplugins/magpie-setup/templates/project.mdandtools/chat/README.md.docs/adapters/registry.mdchat row to listtools/chat-discord/as shipping, with Matrix (feat(tools/matrix): chat bridge for projects whose primary chat is Matrix / Element #309) and Zulip (feat(tools/zulip): chat bridge for projects whose primary chat is Zulip #308) tracking links.tools/spec-loop/specs/adapters.mdandcontributor-growth.md) to reflect Discord as a shipping adapter alongside Slack, noting Matrix and Zulip remain extension points.Type of change
docs/,README.md, comments)tools/<system>/*.md)Test plan
doctocTOC generation andmarkdownlint-cli2across all modified Markdown files.spec-validateontools/spec-loop/specs/.RFC-AI-0004 compliance
contract:chat.Linked issues
Closes #1421
🤖 Generated with Antigravity