Repository navigation
feat(pr-management): plug skill families into the tool, and guard review mentions - #1579
Merged
Merged
Conversation
potiuk
added
family:pr-management
github-actions
Bot
added
family:setup
potiuk
added this pull request to stack #1586
October 10, 2026 09:23
potiuk
force-pushed
the
perf/pr-mgmt-4-infra
branch
from
October 10, 2026 09:46
9ea3d17 to
9358aa1
Compare
…iew mentions Groundwork for moving the remaining pr-management skills onto tools/pr-management: - `pr-management` discovers a family's subcommands from `pr_management.<family>.cli` (`FAMILY`, `add_parsers`, `dispatch`), and vetted-ops loads per-family `ops_<family>.py` modules shipped in the package, so each skill adds its commands and reads without editing a shared file. The catalogue stays closed: only modules inside the package load. - The agent-guard `mention` guard now covers review posting (`gh pr review --body/--body-file`) and every value a non-GET `gh api` call sends, whatever the endpoint — every `-f` / `-F` / `--raw-field` / `--field` value in each spelling `gh` accepts (`-fk=v`, `--field=k=v`, `@file` read) and every `--input` string: such text may @-mention nobody. No endpoint or mutation list to fall behind. Text it cannot read (a body on stdin, an unreadable body or field file) is refused instead of passing unseen. - It also allows the one mention the mentoring hand-off exists to make: the `maintainer_team_handle` of the committed `.apache-magpie-overrides/mentoring-config.md`, alone, in a body that opens with the hand-off template's "— handing this off:" line. The file must be tracked and identical to HEAD (an uncommitted edit, or a scratch repository, does not count), the personal layer is never read for it, and the team must belong to the organisation that owns the target repository. Generated-by: Claude Opus 5
potiuk
force-pushed
the
perf/pr-mgmt-4-infra
branch
from
October 10, 2026 11:03
9358aa1 to
173bb56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Groundwork for moving the remaining
pr-managementskills ontotools/pr-management, after #1570 / #1571 / #1572:pr-managementdiscovers a family's subcommands frompr_management.<family>.cli(FAMILY,add_parsers,dispatch), and vetted-ops loads per-familyops_<family>.pymodules shipped in the package, so each skill adds its commands and reads without editing a shared file. The catalogue stays closed: only modules inside the package load.mentionguard now also covers review posting (gh pr review --body/--body-file) and every value a non-GETgh apicall sends, whatever the endpoint: every-f/-F/--raw-field/--fieldspellingghaccepts (including@file) and every--inputstring. No endpoint or mutation list to fall behind. Text it cannot read (stdin, an unreadable file) is refused instead of passing unseen.Bottom of a stack of seven; each skill PR above builds on this one.
Security notes
The hand-off exemption here trusts a committed, unmodified local
mentoring-config.md. The top PR of the stack (mention allowlist) replaces that with a read from the target repository's default branch on GitHub, so a scratch repository the agent creates cannot satisfy it. Please merge the stack together rather than this PR alone.Type of change
Test plan
prek run --all-filespassesgh apiwrite spelling, uninspectable bodies and the hand-off exemptiontools/pr-managementand vetted-ops pytest / ruff / mypyWas generative AI tooling used to co-author this PR?
Generated-by:.🤖 Generated with Claude Code
https://claude.ai/code/session_01GTPsZ5aEE5bUVYqp47Dpvv