Skip to content

fix(pr-management-stats): make the multi-line dashboard strings explicit - #1588

Merged
potiuk merged 1 commit into
mainfrom
fix/stats-dashboard-concat
Oct 10, 2026
Merged

potiuk merged 1 commit into
mainfrom
fix/stats-dashboard-concat

Conversation

@potiuk

@potiuk potiuk commented Oct 10, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to #1572. Three list elements in the stats dashboard renderer were split across lines with implicit string concatenation. That reads like a missing comma, and CodeQL flags it (py/implicit-string-concatenation-in-list, alert #118 on main). Each is now one parenthesised string; the rendered HTML is unchanged.

Type of change

  • Python package (no behaviour change)

Test plan

  • prek run on the change passes, including the tools/pr-management pytest / ruff / mypy hooks

Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5). I reviewed the diff and the test results; the commit carries Generated-by:.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GTPsZ5aEE5bUVYqp47Dpvv

Three list elements in the dashboard renderer were split across lines
with implicit string concatenation, which reads like a missing comma
and is flagged by CodeQL (py/implicit-string-concatenation-in-list).
Each is now one parenthesised string; the rendered HTML is unchanged.

Generated-by: Claude Opus 5
Claude-Session: https://claude.ai/code/session_01GTPsZ5aEE5bUVYqp47Dpvv
@potiuk potiuk added family:pr-management pr-management-* skills capability:stats Read-only dashboards, metrics, governance evidence labels Oct 10, 2026
@github-actions github-actions Bot added family:tools tools/* substrate:analytics Tool substrate: read-only metrics / dashboards / renderers labels Oct 10, 2026
@potiuk
potiuk merged commit 521fc85 into main Oct 10, 2026
10 checks passed
@potiuk
potiuk deleted the fix/stats-dashboard-concat branch October 10, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

capability:stats Read-only dashboards, metrics, governance evidence family:pr-management pr-management-* skills family:tools tools/* substrate:analytics Tool substrate: read-only metrics / dashboards / renderers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant