Conversation
Removes API element which does not exist in JDK8
Errors captured during async tasks will now be stored and re-thrown during valid filterchain operations. This allows the filterchain to capture exceptions. I may need to disable ENABLE_ASYNC_TASKS later to ensure that the filterchain captures all exceptions quickly.
…ServiceStatistics calculation configurable
DIRMINA-1152: IoServiceStatistics introduces huge latencies
* Adds SSL inboundDone check and throws illegal state * Fixes spelling mistake in SSLHandler * Read/Write improvements to SslFilterTest
* Adds ENABLE_SOFT_CLOSURE as a toggle
…anymore supported in TLS 1.3
o Addition of Javadoc
This is necessary when a TLS error has occured and teh inbound is
therefore closed, the Alert must still be sent to the remote peer.
o Added some missing Javadoc
o Code formatting to respect the MINA current code style (no useless
final, this, added missing {}, added NL, etc)
… closed." This reverts commit ecc9972.
o Used meaningful variable nales o Removed useless 'this' o Removed useless 'final' o Transmitted the nexwt filter to the throw_pending_error() method in order to be able to write back the Alert to the remote peer o Write the Alter back to the remote peer in the receive_loop() method when the inbound has been closed following an error while processing a task o Quick exit the receive_loop() method if the read message is empty o Minor formatting (added nl, etc) o Added missing javadoc
o Some minor code formatting
…s repo does not contain anymore the 2.2.0 release
Fix ipv6 filtering
…f byte[] (provided by Maxime Besson)
…tManagerFactory.xl file
interacting with a MDC test (which has tobe fixed) o Don't increase the number of written messages when the message is a TLS one (DIRMINA-1146) o Simplified the messageSent method in SslFilter o Cleaned up the SslFilterTest o Added a test to check that messages sent are correctly counted when using TLS (DIRMINA-1146)
[DIRMINA-1146] Additional unit test checks
… due to byte alignment)
…mat change in IoBuffer.putObject/getObject)
…s-id SslIdentificationAlgorithmTest - do not resolve DNS for custom hostnames
- use timeouts to avoid waiting indefinitely
…ion-test DIRMINA777Test fix
|
Wrong branch... :( |
|
FTR, we have 3 'live' branches:
The question is whether we backport the fixes from 2.2.X to 2.1.X and 2.0.X or decide to 'kill' the two latest branches... The problem being that we have pretty much 40% of the downloads for those versions (and we are talking about more than 1M download every month...): 2.0.X: 346 417 downloads last month (we even have 23 149 downloads for MINA 1.1.X which is 'dead' since April 23th 2008... 18 years ago!) |
|
That's a good point. I assumed that 2.2.x is the only one used. I will port this one - #68 to other branches as well. I will also look at the additional changes I made to 2.2.x and try to merge it. |
|
Wait, the idea is probably to have a discussion about whether we maintain those branches or not. At some point, it's pretty sure they have many issues that aren't fixed. This is a discussion worth to hace on the MINA dev Mailing List IMHO. |
12 participants
https://github.com/apache/mina/actions/runs/35831174047/job/107083881501
org.apache.mina.filter.logging.MdcInjectionFilterTest#testOnlyRemoteAddresssometimes fails due to additional log event sneaking in without remote address:mina/mina-core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoProcessor.java
Line 702 in 0813a77
There are already some comments about logging in this file causing problems with
MdcInjectionFilterTestmina/mina-core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoProcessor.java
Line 684 in 0813a77
The disposing sessions log is quite new.
Changes
org.apache.mina.filter.logging.MdcInjectionFilterTest#testOnlyRemoteAddresscoming fromIoProcessorloggerThe test still processes and verifies
org.apache.mina.core.filterchain.IoFilterevents such as: