JSF: avoid suggesting UIComponent default attributes on non-component tags - #9606
Open
NicolaIsotta wants to merge 1 commit into
Open
JSF: avoid suggesting UIComponent default attributes on non-component tags#9606NicolaIsotta wants to merge 1 commit into
NicolaIsotta wants to merge 1 commit into
Conversation
… tags TagImpl no longer inherits generic UIComponent attributes (like 'rendered') across all facelet tags. Introduce a ComponentTag wrapper so default component attributes are only provided for actual UI/composite components. Add tests for the corrections, even if CI doesn't run them at the moment
Contributor
Author
|
To give a visual example, these are the attributes suggestions of For reference: https://jakarta.ee/specifications/faces/4.1/vdldoc/f/ajax |
mbien
added
Java EE/Jakarta EE
Contributor
Author
|
BTW, I managed to make the web.jsf.editor unit tests work. Can I add another commit to this PR, or is it better to open a new one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TagImpl no longer inherits generic UIComponent attributes (like 'rendered') across all facelet tags. Introduce a ComponentTag wrapper so default component attributes are only provided for actual UI/composite components.
Add tests for the corrections, even if CI doesn't run them at the moment
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
LLMs, Commit messages and PR description:
git log) that all commits have a valid name and email address for you in the Author field.Assisted-by: MODEL_NAME MODEL_VERSIONline appended to the commit message.Assisted-byline from above)If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)