Repository navigation
Bring build.xml dependency versions in line with Gradle - #1429
Merged
Merged
Conversation
Update the Ant third-party jar versions to match what the Gradle build resolves, and add the replaced versions to check-jars so that stale jars in a cached lib/ directory get removed. Also fix the stale gradleVersion in the wrapper task (the wrapper itself is already on 9.8.1). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
commons-logging 1.4.0 ships a module-info, so it is no longer an automatic module and pdfbox's use of it fails with NoClassDefFoundError unless it is added as a root module. Also check for the commons-logging jar so that a version bump triggers the download. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Ant build's third-party jars to the versions the Gradle build resolves:
check-jarsso they're deleted from a cachedlib/(the Ant CI job cacheslibunder a fixed key); otherwise old and new jars would both sit on the module path.gradleVersion = '9.6.1'in thewrappertask (the wrapper itself is already 9.8.1). Gradle 9.8.1 and Ant 1.10.18 are both the latest releases.Tested locally with Ant:
test-main -Dtestpattern=TestSheetUtil(mockito) andtest-ooxml -Dtestpattern=TestSignatureInfo(bouncycastle) pass. Also checked thatcheck-jarsremoves dummy old-version jars.🤖 Generated with Claude Code