Repository navigation
WorkbookUtil.validateSheetName: show control chars as U+XXXX - #1435
Merged
pjfanning merged 1 commit intoOct 17, 2026
Merged
Conversation
Follow-up to apache#1433. The error for an invalid sheet-name char embedded the char itself, which for 0x0000 and 0x0003 is invisible in logs. Show control chars as a code point, and assert the full messages in the tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1433.
IllegalArgumentExceptionfor an invalid sheet-name char included the char itself, which is invisible in logs for 0x0000 and 0x0003. Control chars are now shown as a code point, e.g.Invalid char (U+0000) found at index (6) …. Printable chars are shown as before (Invalid char (:) …).Tests:
TestWorkbookUtil(3 tests).🤖 Generated with Claude Code