Ranger 5798: Sanitize Test Connection failure messages to avoid host/port reachability disclosure - #1232
Open
eoinmcdonnell113 wants to merge 2 commits into
Open
Ranger 5798: Sanitize Test Connection failure messages to avoid host/port reachability disclosure#1232eoinmcdonnell113 wants to merge 2 commits into
eoinmcdonnell113 wants to merge 2 commits into
Conversation
…port reachability disclosure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##What changes were proposed in this pull request?
RANGER-5798: Sanitize Test Connection failure messages to avoid host/port reachability disclosure.
Ranger Admin Test Connection (validateConfig) could return low-level network errors such as java.net.ConnectException: Connection refused in the UI. That made it possible to infer whether a host/port was reachable from the Ranger Admin server.
This change:
Sanitizes reachability-related failure messages in ServiceMgr.generateResponseForTestConn and returns a generic UI message instead
Keeps full exception details in the admin log
Leaves intentional config validation errors unchanged (for example SSL requiring an https URL)
Stops appending raw exception text in NiFi / NiFi Registry client Test Connection responses
JIRA: https://issues.apache.org/jira/browse/RANGER-5798
##How was this patch tested?
Unit tests: TestServiceMgr, TestNiFiClient, TestNiFiRegistryClient (all passed)
Manual Test Connection on Ranger Admin UI with a closed port URL: UI showed a generic failure message; admin log still contained Connection refused