Conversation
…ured service-def classes
mneethiraj
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ured service-def classes
What changes were proposed in this pull request?
Several places resolve a configured class name via Class.forName(...).newInstance(), relying on the checkcast to catch a bad class — but the checkcast happens after construction, not before. Add an isAssignableFrom check before instantiation, in the existing try/catch, so an unassignable class is treated the same as an unresolvable one (falls back / skipped, as today).
No new validation mechanism, no behavior change for valid configs. Tests added confirming a non-assignable class is never constructed while legitimate classes still work.
How was this patch tested?
all tests are green and add couple of new tests as well.