Use double-quoted href attributes on the comment management page - #181
Merged
Conversation
The comment management screen wrapped its <s:property/> URL values in single-quoted href attributes. This switches them to double-quoted attributes, matching the convention already used for URL-valued attributes elsewhere in the authoring UI (for example the bookmark URL in Bookmarks.jsp), so externally supplied URL values stay contained within the attribute. Adds a rule to AuthoringUiSinkAuditTest asserting the comment author URL renders inside a double-quoted href. Claude-Session: https://claude.ai/code/session_015X69HHQ5XnjRkJP8ymzwFf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The links on the comment management screen (Comments.jsp) wrapped their
<s:property/>URL values in single-quotedhrefattributes. This switches them to double-quoted attributes, matching the convention already used for URL-valued attributes elsewhere in the authoring UI — for example the bookmark URL inBookmarks.jsp— so externally supplied URL values stay contained within the attribute.A rule is added to
AuthoringUiSinkAuditTestasserting that the comment author URL renders inside a double-quotedhref, keeping the convention going forward.Full
apptest suite green on JDK 11 (298 tests).