Skip to content

[SPARK-60698][CONNECT][PYTHON] Distinguish missing and null Arrow settings in tests - #290

Closed
dbtsai wants to merge 1 commit into
apache:masterfrom
dbtsai:codex/postmerge-pr-134-config-snapshot-tests
Closed

dbtsai wants to merge 1 commit into
apache:masterfrom
dbtsai:codex/postmerge-pr-134-config-snapshot-tests

Conversation

@dbtsai

@dbtsai dbtsai commented Nov 7, 2026

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

The Arrow input settings test parametrized missing and null values, but its mock omitted both from ConfigResponse. Preserve null-valued keys with the optional protobuf value unset and assert the two response shapes. Cover missing and null values for all eight required settings, document the one-shot configuration error hook, and assert the exact snapshot request in the schema handoff test.

Why are the changes needed?

Follow-up to #134 (SPARK-60698). The two previous cases produced identical wire responses, leaving the null-value path untested. Only three of the eight required settings had missing-value coverage.

Does this PR introduce any user-facing change?

No, tests only.

How was this patch tested?

A private wire-level reproduction fails on current master and passes after this change. It executes the actual nested mock Config handler through installed official protobuf classes; all 16 missing/null response cases pass, including response ordering and optional-value presence. Python syntax and git diff --check pass. Tooling unit tests: 12 passed, 2 skipped.

Draft: native runtime and mandatory pre-push validation remain pending. This host has no Cargo/Rust/protoc, so the five required Cargo checks and extension build could not start. The Arrow suite fails at collection without a current-built extension (Row cannot be imported); API introspection and the official parity gate remain unrun. Wire-level checks do not prove the Rust error path. No full validation convergence is claimed.

Was this patch authored or co-authored using generative AI tooling?

Generated-by: OpenAI Codex (GPT-6). Independently source-reviewed using installed local Claude Code.

This pull request and its description were written by Isaac.

…tings in tests

Exercise null-valued configuration response pairs and cover missing values for all eight required Arrow input settings.

Co-authored-by: Isaac <no-reply@databricks.com>
@dbtsai
dbtsai marked this pull request as ready for review November 7, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant