Repository navigation
Conversation
…tings in tests Exercise null-valued configuration response pairs and cover missing values for all eight required Arrow input settings. Co-authored-by: Isaac <no-reply@databricks.com>
dbtsai
marked this pull request as ready for review
November 7, 2026 08:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The Arrow input settings test parametrized missing and null values, but its mock omitted both from
ConfigResponse. Preserve null-valued keys with the optional protobuf value unset and assert the two response shapes. Cover missing and null values for all eight required settings, document the one-shot configuration error hook, and assert the exact snapshot request in the schema handoff test.Why are the changes needed?
Follow-up to #134 (SPARK-60698). The two previous cases produced identical wire responses, leaving the null-value path untested. Only three of the eight required settings had missing-value coverage.
Does this PR introduce any user-facing change?
No, tests only.
How was this patch tested?
A private wire-level reproduction fails on current master and passes after this change. It executes the actual nested mock Config handler through installed official protobuf classes; all 16 missing/null response cases pass, including response ordering and optional-value presence. Python syntax and
git diff --checkpass. Tooling unit tests: 12 passed, 2 skipped.Draft: native runtime and mandatory pre-push validation remain pending. This host has no Cargo/Rust/protoc, so the five required Cargo checks and extension build could not start. The Arrow suite fails at collection without a current-built extension (
Rowcannot be imported); API introspection and the official parity gate remain unrun. Wire-level checks do not prove the Rust error path. No full validation convergence is claimed.Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-6). Independently source-reviewed using installed local Claude Code.
This pull request and its description were written by Isaac.