Repository navigation
Clarify signing key checks before release votes - #714
Conversation
|
@dongjoon-hyun @HyukjinKwon does it make sense? given the discrepancy in apache/spark#59811. happy to change the language any way |
| ``` | ||
|
|
||
| And then append the generated key to the KEYS file by: | ||
| And then append the generated key to the staging KEYS file by: |
There was a problem hiding this comment.
I remember a few years ago (I cannot find the exact email, it happened in the incubating list, many incubating projects were coached there on how to perform an Apache release), ASF asked us to always use .../release/<project>/KEYS in the voting email instead of .../dev/<project>/KEYS.
So we don't need to maintain the .../dev/spark/KEYS actually, and the command can be updated in-place to point to the .../release/<project>/KEYS
There was a problem hiding this comment.
I see, hm. This came when i was trying to do the release, committer can only append keys to dev//KEYS, but not release//KEYS, the latter is automatically populated once release is done iiuc.
the problem is, the VOTE email points to the release KEYS so nobody can validate until that happens and I get some -1 vote. just a one-time problem though. Not sure the solution
There was a problem hiding this comment.
Oops. I missed 142 line in the previous approval. So, I removed it.
To @szehon-ho , we can add line 150 ~ 154, because it's the Apache Spark way.
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you, @szehon-ho .
Release vote emails link to the published release KEYS file. A release manager's
signing key must be present there so voters can verify the candidate.
Document that release managers should check the release KEYS file before starting a
vote. If their key is missing, PMC members can add it themselves; other release
managers should ask their PMC shepherd to add it.
This follows the guidance in apache/spark#59811.
Validation: built the site with Jekyll 4.4.1 in a Ruby 3.4 Docker container, checked
the rendered KEYS guidance and links, and ran
git diff --check.Generated-by: Codex (GPT-6)