Skip to content

#2057 FetcherBolt: extract the response and failure handling - #2206

Merged
rzo1 merged 1 commit into
mainfrom
response-outcome
Oct 2, 2026
Merged

rzo1 merged 1 commit into
mainfrom
response-outcome

Conversation

@dpol1

@dpol1 dpol1 commented Sep 29, 2026

Copy link
Copy Markdown
Member

Moves the mapping from response or exception to status, stream and metadata
to FetchOutcomes, with unit tests. Emits, acks and the finally stay in
FetcherThread. The exception counter is now incremented just before the emit.

Part of #2057.

@dpol1
dpol1 added this pull request to stack #2202 September 29, 2026 09:50
@dpol1 dpol1 added this to the 4.0.0 milestone Sep 29, 2026
@dpol1 dpol1 self-assigned this Sep 29, 2026
@dpol1 dpol1 added the fetcher label Sep 29, 2026
@dpol1
dpol1 requested a review from rzo1 September 29, 2026 09:55
@dpol1 dpol1 added the core label Sep 29, 2026
@dpol1
dpol1 requested review from jnioche, mvolikas and sigee September 29, 2026 09:55
@dpol1 dpol1 linked an issue Sep 29, 2026 that may be closed by this pull request

@jnioche jnioche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have a sub package for all the things extracted from FetcherBolt, like o.a.s.fetcher
There should only be bolt classes in o.a.s.bolt. This is an important package, we want to keep things tidy and not have tons of stuff without much structure

@dpol1

dpol1 commented Sep 29, 2026 •

Copy link
Copy Markdown
Member Author

Good point @jnioche. If i make a dedicated package I'd have to make em public - is that a trade off we want? Just a quick question for now, I'll investigate more later

@rzo1

rzo1 commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

I think it wouldn't be a problem if the Javadoc states, that those classes are intendent for internal use only ;-)

@dpol1

dpol1 commented Sep 29, 2026

Copy link
Copy Markdown
Member Author

sounds good to me @rzo1, thank you 👍 - I'll proceed right away adding another PR to the stack

@dpol1

dpol1 commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

I think we should have a sub package for all the things extracted from FetcherBolt, like o.a.s.fetcher There should only be bolt classes in o.a.s.bolt. This is an important package, we want to keep things tidy and not have tons of stuff without much structure

see #2209

@dpol1 dpol1 removed a link to an issue Oct 1, 2026
@rzo1
rzo1 force-pushed the response-outcome branch 4 times, most recently from bb47e87 to a0476c7 Compare October 2, 2026 18:54
Base automatically changed from crawl-delay-policy to main October 2, 2026 18:54
Signed-off-by: Davide Polato <dpol1@apache.org>
@rzo1
rzo1 force-pushed the response-outcome branch from a0476c7 to 182597a Compare October 2, 2026 18:54
@rzo1
rzo1 dismissed jnioche’s stale review October 2, 2026 18:55

Package extraction was done.

@rzo1
rzo1 merged commit c39f3d0 into main Oct 2, 2026
1 check passed
@dpol1
dpol1 deleted the response-outcome branch October 2, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants