Repository navigation
Conversation
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #45833 +/- ##
==========================================
+ Coverage 84.76% 84.77% +0.01%
==========================================
Files 3072 3072
Lines 206119 206235 +116
Branches 48539 48570 +31
==========================================
+ Hits 174718 174842 +124
+ Misses 28101 28092 -9
- Partials 3300 3301 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The unmatched-parenthesis helper imported sqlglot directly, which the disallowed-sql-import pylint check only permits under superset/sql. It lives there as find_unmatched_parenthesis, with direct tests. Regenerate messages.pot and the .po catalogs for the reworded partition preview messages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fetch-retry re-sends a request that an earlier test aborted, and fetch-mock still runs the route handler for it, so on a slow CI shard those stray calls landed on this test's counter and its 429/500 slot. Ignore calls whose signal is already aborted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hughhhh
force-pushed
the
plan/sc-130303-partition-followup
branch
from
October 31, 2026 18:52
34f50b2 to
fa83d9f
Compare
3 of 9 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Partition preview messages could describe a throttled request or NULL output as a broken transform, claim an invalid expression was already saved, or omit the next step for a missing placeholder or incompatible output type. This change distinguishes those outcomes, offers an explicit retry for unavailable previews, and moves keyboard focus to the transform input after moving a mapping.
It also catches unmatched nested parentheses before warehouse probes and uses readable Hive partition-filter errors in Samples and drill-to-detail. Existing save eligibility, emitted predicates, transform defaults, and cached verdict semantics are preserved.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TExecuteStatementResp(...)→ guidance to add a suitable partition filter.TESTING INSTRUCTIONS
Proof: 642 backend tests and 144 frontend tests pass; staged-file pre-commit checks pass, including mypy and frontend typechecking. Ten new or strengthened backend assertions fail against the unchanged base. Headless Chromium exercised the actual mapping component with controlled HTTP responses and verified focus transfer, accessible placeholder guidance, throttling, and successful retry without page errors.
With
PARTITION_FILTER_MAPPINGenabled:extract(epoch from cast(:value as timestamp)andlower(:value), 'x': expect syntax guidance without a warehouse probe or a claim that the mapping was saved.:value: expect a nonblocking field warning.The Hive driver error shapes are covered by regression tests; a live Hive warehouse was not available for this run.
ADDITIONAL INFORMATION
PARTITION_FILTER_MAPPINGnull_resultReviewed with sol-loop: 1 round with GPT-6.1 Sol. Sol verdict: approved.
Created with GPT-6 Astra in T3 Code through the Codex harness.