[sadpandajoe]

SUMMARY

The nightly pre-commit checks run (prek run --all-files) fails mypy (main) with three errors. Per-PR runs only type-check changed files, and superset_core.* modules that are not on the command line are skipped (follow_imports = "skip") and become Any, so each error only surfaces in the full-tree run.

• feat(semantic-layers): add an SDK conformance kit for providers #45395 introduced the two superset-core errors (semantic_layers/testing.py:154, tests/semantic_layers/conformance_provider.py:153).
• fix(sqla): avoid redundant schema introspection for virtual datasets #45681 introduced the virtual_dataset_connections_test.py error.

Changes, typing only, no runtime behavior change:

• testing.py: [*query.dimensions, *query.metrics] joins to list[object]; build the expected name set from each list instead.
• conformance_provider.py: ORDER BY members may be AdhocExpression, which the existing "not in columns" guard already rejects; add an isinstance filter so mypy can see it.
• virtual_dataset_connections_test.py: annotate the guest rules dict so a rule carrying a dataset id is assignable.

TESTING INSTRUCTIONS

1. With mypy 1.15.0 and the hook's types-* dependencies, run the full tree as the nightly job does: pre-commit run mypy --all-files (or prek run mypy --all-files).
2. On master this reports 3 errors in 3 files; on this branch it reports Success: no issues found.
3. Optionally run pytest superset-core/tests/semantic_layers/ and pytest tests/unit_tests/connectors/sqla/virtual_dataset_connections_test.py to confirm no behavior change.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

Notes:

• The isinstance filter in conformance_provider.py relies on the existing guard just above it; style-only observation from review, no behavior impact.

🤖 Generated with Claude Code

[codeant-ai-for-open-source]

  CodeAnt PR Risk

🟢  Low Risk

• The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: f91f7806b410

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.68%. Comparing base (2d2e557) to head (f91f780).

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #45835   +/-   ##
=======================================
  Coverage   84.68%   84.68%           
=======================================
  Files        3069     3069           
  Lines      205465   205465           
  Branches    48310    48310           
=======================================
  Hits       174006   174006           
  Misses      28169    28169           
  Partials     3290     3290           

Flag	Coverage Δ
hive	34.53% <ø> (ø)
mysql	52.55% <ø> (ø)
postgres	52.56% <ø> (-0.01%)	⬇️
presto	36.26% <ø> (ø)
python	87.73% <ø> (ø)
sqlite	52.32% <ø> (ø)
unit	82.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[aminghadersohi]

Expected member names and unsupported-order rejection are unchanged; the three edited sites are the only mypy errors at the base.