Repository navigation
Conversation
…te class sparsity optimizer to perform complete rewrites of isolated mm chain statement blocks
…o use tabulators consistently
…zer to being a hop rewrite rule instead of statement block rewrite NOTE: hop rewrite rules are also executed after computing the previous statementblock feat(main/hops/rewrite/SparsityOptimizer.java): replicate the optimization from normal sparsity-based mm chain rewrite create the method to "sculpt" a mm chain, which is allowed to completely rewrite the mm chain and ingest a new hop structure feat(test/functions/rewrite/SparsityOptimizerTest.java): create preliminary junit test for the sparsity optimizer
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2630 +/- ##
============================================
+ Coverage 71.49% 72.03% +0.54%
- Complexity 51157 51184 +27
============================================
Files 1646 2101 +455
Lines 198715 228744 +30029
Branches 38640 38657 +17
============================================
+ Hits 142072 164787 +22715
- Misses 45475 52777 +7302
- Partials 11168 11180 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ilar to the mm chain rewrite class chore(test/functions/rewrite/SparsityOptimizerTest.java): set the estimator type explicitly
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there,
this PR adds a separate class for sparsity-based optimizations and for related pre-computations to estimate sparsity. It is appended to the dynamic rewrites.
For now, the sparsity optimizers replicates the sparsity-based matrix multiplication rewrites. In the future, this can be extended to complete re-creation of the computation graph.
All the best,
David