Skip to content

Fix exception type in ReadOnlyStrategy reference docs - #3678

Merged
spmallette merged 1 commit into
apache:masterfrom
spmallette:tp-docs-readonlystrategy-134
Sep 25, 2026
Merged

spmallette merged 1 commit into
apache:masterfrom
spmallette:tp-docs-readonlystrategy-134

Conversation

@spmallette

Copy link
Copy Markdown
Contributor

The prose stated that a mutating traversal throws an IllegalStateException, while the accompanying code comments referred to a VerificationException. Make the prose precise and consistent by naming VerificationException and noting it is a subclass of IllegalStateException, and align the JavaScript and Python comments to the error types those clients actually surface (ResponseError and GremlinServerError).

The prose stated that a mutating traversal throws an IllegalStateException,
while the accompanying code comments referred to a VerificationException.
Make the prose precise and consistent by naming VerificationException and
noting it is a subclass of IllegalStateException, and align the JavaScript
and Python comments to the error types those clients actually surface
(ResponseError and GremlinServerError).

Assisted-by: Kiro:claude-opus-4.8
@spmallette
spmallette merged commit e3df8ed into apache:master Sep 25, 2026
6 checks passed
@spmallette
spmallette deleted the tp-docs-readonlystrategy-134 branch September 25, 2026 11:50
@codecov-commenter

codecov-commenter commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.73%. Comparing base (a28cd1f) to head (0a16f6f).
⚠️ Report is 646 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3678      +/-   ##
============================================
+ Coverage     76.35%   76.73%   +0.37%     
- Complexity    13424    14341     +917     
============================================
  Files          1012     1037      +25     
  Lines         60341    64761    +4420     
  Branches       7075     7695     +620     
============================================
+ Hits          46076    49695    +3619     
- Misses        11548    11976     +428     
- Partials       2717     3090     +373     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants