Correct Gremlin-Go set and composite-map-key deserialization docs - #3679
Open
spmallette wants to merge 1 commit into
Open
spmallette wants to merge 1 commit into
spmallette wants to merge 1 commit into
Conversation
The Limitations section stated that server set type codes deserialize into slices and that GraphBinary maps with non-comparable keys are unsupported. In practice a set type code deserializes into a *gremlingo.SimpleSet and composite/non-comparable map keys are deserialized lossily rather than rejected. Update both bullets to describe the actual behavior. Assisted-by: Kiro:claude-opus-4.8
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3679 +/- ##
============================================
- Coverage 76.35% 76.29% -0.07%
- Complexity 13424 14334 +910
============================================
Files 1012 1005 -7
Lines 60341 57848 -2493
Branches 7075 7695 +620
============================================
- Hits 46076 44134 -1942
+ Misses 11548 10946 -602
- Partials 2717 2768 +51 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Limitations section stated that server set type codes deserialize into slices and that GraphBinary maps with non-comparable keys are unsupported. In practice a set type code deserializes into a *gremlingo.SimpleSet and composite/non-comparable map keys are deserialized lossily rather than rejected. Update both bullets to describe the actual behavior.