Skip to content

chore: move agent skills to api7/agent-skills - #62

Merged
guoqqqi merged 2 commits into
mainfrom
chore/move-skills-to-agent-skills
Sep 11, 2026
Merged

guoqqqi merged 2 commits into
mainfrom
chore/move-skills-to-agent-skills

Conversation

@juzhiyuan

@juzhiyuan juzhiyuan commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

The a6 agent skills moved to api7/agent-skills (skills/a6/), published at https://skills.sh/api7/agent-skills/a6. This repository keeps the CLI and the test that guarantees the skill examples match it.

Removed

  • skills/ (40 flat skill directories) and scripts/validate-skills.sh

Changed

  • test/skills: reads the skill from SKILLS_DIR (default ../agent-skills/skills/a6; skips with a hint if absent, fails if explicitly set but missing). Validates SKILL.md plus every references/**/*.md; all other assertions unchanged.
  • .github/workflows/ci.yml: checks out api7/agent-skills and runs make test-skills against it; adds a daily schedule so drift between this CLI and the references surfaces within 24h.
  • Makefile: test-skills exports SKILLS_DIR; validate-skills removed.
  • install.sh: no-Node fallback now pulls the api7/agent-skills tarball and copies skills/a6 only. Recommended install: npx skills add api7/agent-skills --skill a6.
  • docs/skills.md, README.md, AGENTS.md: point at the new repository.
  • .github/PULL_REQUEST_TEMPLATE.md: ordering rule — add a command → merge CLI first, then the reference; remove/rename → merge the reference change first, then the CLI.

Verification

  • go test ./test/skills -count=1 with SKILLS_DIR pointing at api7/agent-skills: PASS — every a6 … invocation in the 40 references is valid on the current CLI.
  • go build ./... && go vet ./... clean; gofmt -l . clean.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • The installer now provides the single a6 agent skill from the dedicated agent-skills repository.
    • Added guidance for installing and browsing the a6 skill with supported installation methods.
  • Documentation

    • Updated project documentation to reflect the centralized skill location and current testing workflow.
    • Added a pull request template with summary and agent-skills synchronization guidance.
  • Chores

    • Skill examples are now validated against the external repository, including scheduled daily CI checks.
    • The previous collection of in-repository skill documents is no longer included.

Skill content now lives in https://github.com/api7/agent-skills (skills/a6).
test/skills validates that checkout via SKILLS_DIR; install.sh pulls from the
new repository; recommended install is: npx skills add api7/agent-skills --skill a6
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: fe2a57e3-9ade-49e7-95e1-7b801e96acc4

📥 Commits

Reviewing files that changed from the base of the PR and between 22f9c99 and ff9760b.

📒 Files selected for processing (50)
  • .github/PULL_REQUEST_TEMPLATE.md
  • .github/workflows/ci.yml
  • AGENTS.md
  • Makefile
  • README.md
  • docs/roadmap.md
  • docs/skills.md
  • install.sh
  • scripts/validate-skills.sh
  • skills/a6-persona-developer/SKILL.md
  • skills/a6-persona-operator/SKILL.md
  • skills/a6-plugin-ai-content-moderation/SKILL.md
  • skills/a6-plugin-ai-prompt-decorator/SKILL.md
  • skills/a6-plugin-ai-prompt-template/SKILL.md
  • skills/a6-plugin-ai-proxy/SKILL.md
  • skills/a6-plugin-basic-auth/SKILL.md
  • skills/a6-plugin-consumer-restriction/SKILL.md
  • skills/a6-plugin-cors/SKILL.md
  • skills/a6-plugin-datadog/SKILL.md
  • skills/a6-plugin-ext-plugin/SKILL.md
  • skills/a6-plugin-fault-injection/SKILL.md
  • skills/a6-plugin-grpc-transcode/SKILL.md
  • skills/a6-plugin-hmac-auth/SKILL.md
  • skills/a6-plugin-http-logger/SKILL.md
  • skills/a6-plugin-ip-restriction/SKILL.md
  • skills/a6-plugin-jwt-auth/SKILL.md
  • skills/a6-plugin-kafka-logger/SKILL.md
  • skills/a6-plugin-key-auth/SKILL.md
  • skills/a6-plugin-limit-count/SKILL.md
  • skills/a6-plugin-limit-req/SKILL.md
  • skills/a6-plugin-openid-connect/SKILL.md
  • skills/a6-plugin-prometheus/SKILL.md
  • skills/a6-plugin-proxy-rewrite/SKILL.md
  • skills/a6-plugin-redirect/SKILL.md
  • skills/a6-plugin-response-rewrite/SKILL.md
  • skills/a6-plugin-serverless/SKILL.md
  • skills/a6-plugin-skywalking/SKILL.md
  • skills/a6-plugin-traffic-split/SKILL.md
  • skills/a6-plugin-wolf-rbac/SKILL.md
  • skills/a6-plugin-zipkin/SKILL.md
  • skills/a6-recipe-api-versioning/SKILL.md
  • skills/a6-recipe-blue-green/SKILL.md
  • skills/a6-recipe-canary/SKILL.md
  • skills/a6-recipe-circuit-breaker/SKILL.md
  • skills/a6-recipe-graphql-proxy/SKILL.md
  • skills/a6-recipe-health-check/SKILL.md
  • skills/a6-recipe-mtls/SKILL.md
  • skills/a6-recipe-multi-tenant/SKILL.md
  • skills/a6-shared/SKILL.md
  • test/skills/skills_test.go
💤 Files with no reviewable changes (41)
  • skills/a6-plugin-basic-auth/SKILL.md
  • skills/a6-plugin-ai-proxy/SKILL.md
  • skills/a6-plugin-key-auth/SKILL.md
  • skills/a6-recipe-multi-tenant/SKILL.md
  • skills/a6-plugin-openid-connect/SKILL.md
  • skills/a6-shared/SKILL.md
  • skills/a6-recipe-blue-green/SKILL.md
  • skills/a6-persona-developer/SKILL.md
  • skills/a6-plugin-wolf-rbac/SKILL.md
  • skills/a6-plugin-ip-restriction/SKILL.md
  • scripts/validate-skills.sh
  • skills/a6-plugin-ai-prompt-template/SKILL.md
  • skills/a6-recipe-mtls/SKILL.md
  • skills/a6-plugin-limit-count/SKILL.md
  • skills/a6-recipe-graphql-proxy/SKILL.md
  • skills/a6-plugin-proxy-rewrite/SKILL.md
  • skills/a6-plugin-cors/SKILL.md
  • skills/a6-persona-operator/SKILL.md
  • skills/a6-plugin-ai-prompt-decorator/SKILL.md
  • skills/a6-plugin-prometheus/SKILL.md
  • skills/a6-plugin-consumer-restriction/SKILL.md
  • skills/a6-plugin-grpc-transcode/SKILL.md
  • skills/a6-plugin-traffic-split/SKILL.md
  • skills/a6-recipe-circuit-breaker/SKILL.md
  • skills/a6-plugin-zipkin/SKILL.md
  • skills/a6-plugin-limit-req/SKILL.md
  • skills/a6-plugin-skywalking/SKILL.md
  • skills/a6-plugin-http-logger/SKILL.md
  • skills/a6-plugin-jwt-auth/SKILL.md
  • skills/a6-plugin-redirect/SKILL.md
  • skills/a6-plugin-serverless/SKILL.md
  • skills/a6-plugin-response-rewrite/SKILL.md
  • skills/a6-plugin-hmac-auth/SKILL.md
  • skills/a6-plugin-ext-plugin/SKILL.md
  • skills/a6-plugin-ai-content-moderation/SKILL.md
  • skills/a6-plugin-kafka-logger/SKILL.md
  • skills/a6-plugin-datadog/SKILL.md
  • skills/a6-recipe-canary/SKILL.md
  • skills/a6-plugin-fault-injection/SKILL.md
  • skills/a6-recipe-api-versioning/SKILL.md
  • skills/a6-recipe-health-check/SKILL.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR moves the a6 skill to api7/agent-skills, removes in-repository skill files and validation, updates installation and CI, and revises documentation and contributor guidance.

Changes

Agent skill externalization

Layer / File(s) Summary
External skill source and installation
install.sh, skills/*, scripts/validate-skills.sh
The repository removes its built-in skills and validator. install.sh downloads and installs only the external a6 skill.
External skill validation
test/skills/skills_test.go, Makefile, .github/workflows/ci.yml
Skill tests use SKILLS_DIR. Make and CI obtain skills from an api7/agent-skills checkout. CI also runs daily.
Documentation and contributor workflow
README.md, docs/skills.md, docs/roadmap.md, AGENTS.md, .github/PULL_REQUEST_TEMPLATE.md
Documentation describes the external skill, installation methods, validation commands, and synchronization checklist.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other

Suggested reviewers: moonming

Merge Risk: ⚪ Minimal · up to ff976

The external skill migration, installation path, validation setup, and documentation updates are consistent across the changed workflows.

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
E2e Test Quality Review ⚠️ Warning Blocking issue: the changed validation is not an E2E test. test/skills/skills_test.go builds a6, runs help commands, and parses command and flag names from Markdown. It never executes the skill wo… Add an E2E job or test that checks out api7/agent-skills, starts the required APISIX services, executes representative commands from the external references, and verifies the resulting Admin API and gateway behavior. Add an integration te…
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: moving the agent skills to the api7/agent-skills repository.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Check ✅ Passed No security failure condition was introduced by this pull request. The changed files contain documentation, CI wiring, the installer, and skill-test path changes; they add no API handlers, database mo…
Full details: E2e Test Quality Review

Explanation

Blocking issue: the changed validation is not an E2E test. test/skills/skills_test.go builds a6, runs help commands, and parses command and flag names from Markdown. It never executes the skill workflow against APISIX or verifies the changed install.sh download-and-copy flow. CI runs only make test-skills; the real APISIX tests remain separate e2e-tagged files and are not changed or run by this workflow. Therefore the external skill → CLI → APISIX flow is not covered.

Resolution

Add an E2E job or test that checks out api7/agent-skills, starts the required APISIX services, executes representative commands from the external references, and verifies the resulting Admin API and gateway behavior. Add an integration test for install.sh that exercises successful installation into a temporary directory and failure cases such as an invalid download or missing skills/a6/SKILL.md. Keep the existing syntax validation as a fast complementary test.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/move-skills-to-agent-skills

Comment @coderabbitai help to get the list of available commands.

@guoqqqi
guoqqqi merged commit 48d482e into main Sep 11, 2026
6 checks passed
@guoqqqi
guoqqqi deleted the chore/move-skills-to-agent-skills branch September 11, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants