Repository navigation
K2GO-572 chore(release): v1.2.0-rc.2 (versionCode 73), rc label in versionName - #779
Merged
Merged
Conversation
…rsionName The binary, Play release and R2 files name the candidate they are. Notes add the single-APK line.
versionName carries the build label. play-candidate tags its versionName as the next rc; play-release and the release build refuse a commit whose versionName is not the exact final tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
v1.2.0-rc.2, versionCode 73 (Play 730).play_publish.py:planrequires versionName to be the next candidate; newcheck-releaserefuses a build whose versionName is not the exact final tag.play-release.ymlandandroid-release-build.ymlruncheck-releasebefore any tag, build or upload.play-candidate.ymltags its versionName.Why
Verifications
v1.2.0-rc.1is tagged; check-release v1.2.0 -> refused.K2Go-v1.2.0-rc.2-release.apk,K2Go-v1.2.0-rc.2-play-release.aab.Notes
v1.2.0-rc.1.