Skip to content

K2GO-559 Logs do not identify the user (bake patches + dash-node 1.6.2) - #782

Merged
luisguzman-adfa merged 5 commits into
mainfrom
chore/K2GO-559-log-less
Nov 14, 2026
Merged

luisguzman-adfa merged 5 commits into
mainfrom
chore/K2GO-559-log-less

Conversation

@luisguzman-adfa

Copy link
Copy Markdown
Collaborator

What changes

  • Bake, tools/upstream-patches 0010-0012: nginx access log without the client IP and the User-Agent (the fields stay as -, so awstats still parses the log); Forgejo router log off (LOGGER_ROUTER_MODE empty); Calibre-Web log level INFO in a new app.db (the shipped app.db is DEBUG).
  • dash-node 1.6.2: an installed box gets the same change once, at the first start (marker /library/dashboard/log-less.done). A value that an admin changed is kept.
  • dash-node 1.6.2: when a changed service runs the new config, its older logs are removed once: the rotated copies are deleted and the live log is emptied (marker /library/dashboard/log-less-purge.done).

Why

Steps to QA

  • Baseline (dash-node 1.6.1): open a library page from another device. /var/log/nginx/access.log has the client IP and the User-Agent.
  • Change: rebuild dash-node from this branch and restart the box. The same request logs - - ... "-". log-less.done lists the changed services. After the next box start, the old access.log.N[.gz] files are gone and log-less-purge.done exists.

Verifications

  • dash-node: 172 tests pass (1 symlink test skips on Windows), tsc --noEmit clean.
  • Patches 0010-0012 apply forward and reverse on iiab master c746edde4 after 0001-0009.
  • Calibre-Web SQL checked on a copy of the shipped app.db (level 10 -> 20).
  • Device test: pending. Evidence goes to Jira.

Notes

  • awstats still parses the log, but it no longer counts visitors or browsers.
  • nginx error.log still records client: <IP> for failed requests (out of scope).
  • Forgejo applies at the next app open (its app.ini is newer than the process, so it reads as a pending privacy change). nginx and Calibre-Web apply at the next box start.
  • No APK change.

nginx access log without client IP and User-Agent (fields kept as "-" for awstats), Forgejo router log off, Calibre-Web log level INFO in a new app.db (DEBUG logs session data).
…oxes

Same change as bake patches 0010-0012, at the first dash-node start; marker /library/dashboard/log-less.done. A value the admin changed is kept.
After a changed service runs the new log config, delete its rotated logs from before the change and empty its live log. Marker /library/dashboard/log-less-purge.done.
… config change

A copy rotated before the restart still came from the old config.
@luisguzman-adfa
luisguzman-adfa merged commit 2411cc2 into main Nov 14, 2026
5 checks passed
@luisguzman-adfa
luisguzman-adfa deleted the chore/K2GO-559-log-less branch November 14, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant