Repository navigation
K2GO-559 Logs do not identify the user (bake patches + dash-node 1.6.2) - #782
Merged
Merged
Conversation
nginx access log without client IP and User-Agent (fields kept as "-" for awstats), Forgejo router log off, Calibre-Web log level INFO in a new app.db (DEBUG logs session data).
…oxes Same change as bake patches 0010-0012, at the first dash-node start; marker /library/dashboard/log-less.done. A value the admin changed is kept.
After a changed service runs the new log config, delete its rotated logs from before the change and empty its live log. Marker /library/dashboard/log-less-purge.done.
… config change A copy rotated before the restart still came from the old config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
tools/upstream-patches0010-0012: nginx access log without the client IP and the User-Agent (the fields stay as-, so awstats still parses the log); Forgejo router log off (LOGGER_ROUTER_MODEempty); Calibre-Web log level INFO in a newapp.db(the shippedapp.dbis DEBUG)./library/dashboard/log-less.done). A value that an admin changed is kept./library/dashboard/log-less-purge.done).Why
Steps to QA
/var/log/nginx/access.loghas the client IP and the User-Agent.- - ... "-".log-less.donelists the changed services. After the next box start, the oldaccess.log.N[.gz]files are gone andlog-less-purge.doneexists.Verifications
tsc --noEmitclean.c746edde4after 0001-0009.app.db(level 10 -> 20).Notes
error.logstill recordsclient: <IP>for failed requests (out of scope).app.iniis newer than the process, so it reads as a pending privacy change). nginx and Calibre-Web apply at the next box start.